Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

Issue 2902273002: DevTools: convert linkifyURL params into options object (Closed)
Patch Set: rebase and ac Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org> 3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org>
4 * Copyright (C) 2011 Google Inc. All rights reserved. 4 * Copyright (C) 2011 Google Inc. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 911 matching lines...) Expand 10 before | Expand all | Expand 10 after
922 this._initiatorCell = cell; 922 this._initiatorCell = cell;
923 var request = this._request; 923 var request = this._request;
924 var initiator = NetworkLog.networkLog.initiatorInfoForRequest(request); 924 var initiator = NetworkLog.networkLog.initiatorInfoForRequest(request);
925 925
926 if (request.timing && request.timing.pushStart) 926 if (request.timing && request.timing.pushStart)
927 cell.appendChild(createTextNode(Common.UIString('Push / '))); 927 cell.appendChild(createTextNode(Common.UIString('Push / ')));
928 switch (initiator.type) { 928 switch (initiator.type) {
929 case SDK.NetworkRequest.InitiatorType.Parser: 929 case SDK.NetworkRequest.InitiatorType.Parser:
930 cell.title = initiator.url + ':' + (initiator.lineNumber + 1); 930 cell.title = initiator.url + ':' + (initiator.lineNumber + 1);
931 var uiSourceCode = Workspace.workspace.uiSourceCodeForURL(initiator.url) ; 931 var uiSourceCode = Workspace.workspace.uiSourceCodeForURL(initiator.url) ;
932 cell.appendChild(Components.Linkifier.linkifyURL( 932 cell.appendChild(Components.Linkifier.linkifyURL(initiator.url, {
933 initiator.url, uiSourceCode ? uiSourceCode.displayName() : undefined , '', initiator.lineNumber, 933 text: uiSourceCode ? uiSourceCode.displayName() : undefined,
934 initiator.columnNumber)); 934 lineNumber: initiator.lineNumber,
935 columnNumber: initiator.columnNumber
936 }));
935 this._appendSubtitle(cell, Common.UIString('Parser')); 937 this._appendSubtitle(cell, Common.UIString('Parser'));
936 break; 938 break;
937 939
938 case SDK.NetworkRequest.InitiatorType.Redirect: 940 case SDK.NetworkRequest.InitiatorType.Redirect:
939 cell.title = initiator.url; 941 cell.title = initiator.url;
940 console.assert(request.redirectSource); 942 console.assert(request.redirectSource);
941 var redirectSource = /** @type {!SDK.NetworkRequest} */ (request.redirec tSource); 943 var redirectSource = /** @type {!SDK.NetworkRequest} */ (request.redirec tSource);
942 if (this.parentView().nodeForRequest(redirectSource)) { 944 if (this.parentView().nodeForRequest(redirectSource)) {
943 cell.appendChild( 945 cell.appendChild(
944 Components.Linkifier.linkifyRevealable(redirectSource, Bindings.di splayNameForURL(redirectSource.url()))); 946 Components.Linkifier.linkifyRevealable(redirectSource, Bindings.di splayNameForURL(redirectSource.url())));
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
1037 * @param {boolean=} supressSelectedEvent 1039 * @param {boolean=} supressSelectedEvent
1038 */ 1040 */
1039 select(supressSelectedEvent) { 1041 select(supressSelectedEvent) {
1040 if (this.expanded) { 1042 if (this.expanded) {
1041 this.collapse(); 1043 this.collapse();
1042 return; 1044 return;
1043 } 1045 }
1044 this.expand(); 1046 this.expand();
1045 } 1047 }
1046 }; 1048 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698