Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

Issue 2902273002: DevTools: convert linkifyURL params into options object (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * Copyright (C) 2012 Intel Inc. All rights reserved. 3 * Copyright (C) 2012 Intel Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 620 matching lines...) Expand 10 before | Expand all | Expand 10 after
631 case recordType.ResizeImage: 631 case recordType.ResizeImage:
632 case recordType.DecodeLazyPixelRef: 632 case recordType.DecodeLazyPixelRef:
633 case recordType.XHRReadyStateChange: 633 case recordType.XHRReadyStateChange:
634 case recordType.XHRLoad: 634 case recordType.XHRLoad:
635 case recordType.ResourceSendRequest: 635 case recordType.ResourceSendRequest:
636 case recordType.ResourceReceivedData: 636 case recordType.ResourceReceivedData:
637 case recordType.ResourceReceiveResponse: 637 case recordType.ResourceReceiveResponse:
638 case recordType.ResourceFinish: 638 case recordType.ResourceFinish:
639 var url = TimelineModel.TimelineData.forEvent(event).url; 639 var url = TimelineModel.TimelineData.forEvent(event).url;
640 if (url) 640 if (url)
641 details = Components.Linkifier.linkifyURL(url); 641 details = Components.Linkifier.linkifyURL({url: url});
642 break; 642 break;
643 case recordType.FunctionCall: 643 case recordType.FunctionCall:
644 case recordType.JSFrame: 644 case recordType.JSFrame:
645 details = createElement('span'); 645 details = createElement('span');
646 details.createTextChild(Timeline.TimelineUIUtils.frameDisplayName(eventD ata)); 646 details.createTextChild(Timeline.TimelineUIUtils.frameDisplayName(eventD ata));
647 const location = linkifyLocation( 647 const location = linkifyLocation(
648 eventData['scriptId'], eventData['url'], eventData['lineNumber'], ev entData['columnNumber']); 648 eventData['scriptId'], eventData['url'], eventData['lineNumber'], ev entData['columnNumber']);
649 if (location) { 649 if (location) {
650 details.createTextChild(' @ '); 650 details.createTextChild(' @ ');
651 details.appendChild(location); 651 details.appendChild(location);
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
783 break; 783 break;
784 case recordTypes.FireAnimationFrame: 784 case recordTypes.FireAnimationFrame:
785 contentHelper.appendTextRow(Common.UIString('Callback ID'), eventData['i d']); 785 contentHelper.appendTextRow(Common.UIString('Callback ID'), eventData['i d']);
786 break; 786 break;
787 case recordTypes.ResourceSendRequest: 787 case recordTypes.ResourceSendRequest:
788 case recordTypes.ResourceReceiveResponse: 788 case recordTypes.ResourceReceiveResponse:
789 case recordTypes.ResourceReceivedData: 789 case recordTypes.ResourceReceivedData:
790 case recordTypes.ResourceFinish: 790 case recordTypes.ResourceFinish:
791 url = timelineData.url; 791 url = timelineData.url;
792 if (url) 792 if (url)
793 contentHelper.appendElementRow(Common.UIString('Resource'), Components .Linkifier.linkifyURL(url)); 793 contentHelper.appendElementRow(Common.UIString('Resource'), Components .Linkifier.linkifyURL({url: url}));
794 if (eventData['requestMethod']) 794 if (eventData['requestMethod'])
795 contentHelper.appendTextRow(Common.UIString('Request Method'), eventDa ta['requestMethod']); 795 contentHelper.appendTextRow(Common.UIString('Request Method'), eventDa ta['requestMethod']);
796 if (typeof eventData['statusCode'] === 'number') 796 if (typeof eventData['statusCode'] === 'number')
797 contentHelper.appendTextRow(Common.UIString('Status Code'), eventData[ 'statusCode']); 797 contentHelper.appendTextRow(Common.UIString('Status Code'), eventData[ 'statusCode']);
798 if (eventData['mimeType']) 798 if (eventData['mimeType'])
799 contentHelper.appendTextRow(Common.UIString('MIME Type'), eventData['m imeType']); 799 contentHelper.appendTextRow(Common.UIString('MIME Type'), eventData['m imeType']);
800 if ('priority' in eventData) { 800 if ('priority' in eventData) {
801 var priority = NetworkConditions.uiLabelForPriority(eventData['priorit y']); 801 var priority = NetworkConditions.uiLabelForPriority(eventData['priorit y']);
802 contentHelper.appendTextRow(Common.UIString('Priority'), priority); 802 contentHelper.appendTextRow(Common.UIString('Priority'), priority);
803 } 803 }
(...skipping 28 matching lines...) Expand all
832 relatedNodeLabel = Common.UIString('Layer Root'); 832 relatedNodeLabel = Common.UIString('Layer Root');
833 break; 833 break;
834 case recordTypes.PaintImage: 834 case recordTypes.PaintImage:
835 case recordTypes.DecodeLazyPixelRef: 835 case recordTypes.DecodeLazyPixelRef:
836 case recordTypes.DecodeImage: 836 case recordTypes.DecodeImage:
837 case recordTypes.ResizeImage: 837 case recordTypes.ResizeImage:
838 case recordTypes.DrawLazyPixelRef: 838 case recordTypes.DrawLazyPixelRef:
839 relatedNodeLabel = Common.UIString('Owner Element'); 839 relatedNodeLabel = Common.UIString('Owner Element');
840 url = timelineData.url; 840 url = timelineData.url;
841 if (url) 841 if (url)
842 contentHelper.appendElementRow(Common.UIString('Image URL'), Component s.Linkifier.linkifyURL(url)); 842 contentHelper.appendElementRow(Common.UIString('Image URL'), Component s.Linkifier.linkifyURL({url: url}));
843 break; 843 break;
844 case recordTypes.ParseAuthorStyleSheet: 844 case recordTypes.ParseAuthorStyleSheet:
845 url = eventData['styleSheetUrl']; 845 url = eventData['styleSheetUrl'];
846 if (url) 846 if (url) {
847 contentHelper.appendElementRow(Common.UIString('Stylesheet URL'), Comp onents.Linkifier.linkifyURL(url)); 847 contentHelper.appendElementRow(
848 Common.UIString('Stylesheet URL'), Components.Linkifier.linkifyURL ({url: url}));
849 }
848 break; 850 break;
849 case recordTypes.UpdateLayoutTree: // We don't want to see default detail s. 851 case recordTypes.UpdateLayoutTree: // We don't want to see default detail s.
850 case recordTypes.RecalculateStyles: 852 case recordTypes.RecalculateStyles:
851 contentHelper.appendTextRow(Common.UIString('Elements Affected'), event. args['elementCount']); 853 contentHelper.appendTextRow(Common.UIString('Elements Affected'), event. args['elementCount']);
852 break; 854 break;
853 case recordTypes.Layout: 855 case recordTypes.Layout:
854 var beginData = event.args['beginData']; 856 var beginData = event.args['beginData'];
855 contentHelper.appendTextRow( 857 contentHelper.appendTextRow(
856 Common.UIString('Nodes That Need Layout'), 858 Common.UIString('Nodes That Need Layout'),
857 Common.UIString('%s of %s', beginData['dirtyObjects'], beginData['to talObjects'])); 859 Common.UIString('%s of %s', beginData['dirtyObjects'], beginData['to talObjects']));
(...skipping 242 matching lines...) Expand 10 before | Expand all | Expand 10 after
1100 */ 1102 */
1101 static async buildNetworkRequestDetails(request, model, linkifier, badgePool) { 1103 static async buildNetworkRequestDetails(request, model, linkifier, badgePool) {
1102 const target = model.targetByEvent(request.children[0]); 1104 const target = model.targetByEvent(request.children[0]);
1103 const contentHelper = new Timeline.TimelineDetailsContentHelper(target, link ifier); 1105 const contentHelper = new Timeline.TimelineDetailsContentHelper(target, link ifier);
1104 const category = Timeline.TimelineUIUtils.networkRequestCategory(request); 1106 const category = Timeline.TimelineUIUtils.networkRequestCategory(request);
1105 const color = Timeline.TimelineUIUtils.networkCategoryColor(category); 1107 const color = Timeline.TimelineUIUtils.networkCategoryColor(category);
1106 contentHelper.addSection(Common.UIString('Network request'), color); 1108 contentHelper.addSection(Common.UIString('Network request'), color);
1107 1109
1108 const duration = request.endTime - (request.startTime || -Infinity); 1110 const duration = request.endTime - (request.startTime || -Infinity);
1109 if (request.url) 1111 if (request.url)
1110 contentHelper.appendElementRow(Common.UIString('URL'), Components.Linkifie r.linkifyURL(request.url)); 1112 contentHelper.appendElementRow(Common.UIString('URL'), Components.Linkifie r.linkifyURL({url: request.url}));
1111 Timeline.TimelineUIUtils._maybeAppendProductToDetails(contentHelper, badgePo ol, request.url); 1113 Timeline.TimelineUIUtils._maybeAppendProductToDetails(contentHelper, badgePo ol, request.url);
1112 if (isFinite(duration)) 1114 if (isFinite(duration))
1113 contentHelper.appendTextRow(Common.UIString('Duration'), Number.millisToSt ring(duration, true)); 1115 contentHelper.appendTextRow(Common.UIString('Duration'), Number.millisToSt ring(duration, true));
1114 if (request.requestMethod) 1116 if (request.requestMethod)
1115 contentHelper.appendTextRow(Common.UIString('Request Method'), request.req uestMethod); 1117 contentHelper.appendTextRow(Common.UIString('Request Method'), request.req uestMethod);
1116 if (typeof request.priority === 'string') { 1118 if (typeof request.priority === 'string') {
1117 const priority = 1119 const priority =
1118 NetworkConditions.uiLabelForPriority(/** @type {!Protocol.Network.Reso urcePriority} */ (request.priority)); 1120 NetworkConditions.uiLabelForPriority(/** @type {!Protocol.Network.Reso urcePriority} */ (request.priority));
1119 contentHelper.appendTextRow(Common.UIString('Priority'), priority); 1121 contentHelper.appendTextRow(Common.UIString('Priority'), priority);
1120 } 1122 }
(...skipping 1163 matching lines...) Expand 10 before | Expand all | Expand 10 after
2284 * @param {string=} warningType 2286 * @param {string=} warningType
2285 */ 2287 */
2286 appendWarningRow(event, warningType) { 2288 appendWarningRow(event, warningType) {
2287 var warning = Timeline.TimelineUIUtils.eventWarning(event, warningType); 2289 var warning = Timeline.TimelineUIUtils.eventWarning(event, warningType);
2288 if (warning) 2290 if (warning)
2289 this.appendElementRow(Common.UIString('Warning'), warning, true); 2291 this.appendElementRow(Common.UIString('Warning'), warning, true);
2290 } 2292 }
2291 }; 2293 };
2292 2294
2293 Timeline.TimelineUIUtils._categoryBreakdownCacheSymbol = Symbol('categoryBreakdo wnCache'); 2295 Timeline.TimelineUIUtils._categoryBreakdownCacheSymbol = Symbol('categoryBreakdo wnCache');
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698