Settings: Users: Make isCurrentUserOwner async

Settings: Users: Make isCurrentUserOwner async

BUG=724421
Review-Url: https://codereview.chromium.org/2902253004
Cr-Commit-Position: refs/heads/master@{#475584}
Committed: https://chromium.googlesource.com/chromium/src/+/08449a9d4ce38aeb0c5e0519e1f09fc1de1a42a0

[stevenjb, 2017-05-25 23:46:18]

stevenjb@chromium.org changed reviewers:
+ xiyuan@chromium.org

[stevenjb, 2017-05-25 23:57:32]

https://codereview.chromium.org/2902253004/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/extensions/users_private/users_private_api.cc
(right):

https://codereview.chromium.org/2902253004/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/extensions/users_private/users_private_api.cc:219:
&UsersPrivateIsCurrentUserOwnerFunction::IsOwnerCallback, this));
Unfortunately this never responds in the apitest (browser_tests
--gtest_filter=*UsersPrivete*Owner). Is there an easy way to ensure this will
respond in a test?

[xiyuan, 2017-05-26 16:21:39]

lgtm

https://codereview.chromium.org/2902253004/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/extensions/users_private/users_private_api.cc
(right):

https://codereview.chromium.org/2902253004/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/extensions/users_private/users_private_api.cc:27:
#include "components/ownership/owner_settings_service.h"
nit: Do we need this since we have the owner_settings_service_chromeos.h
included already ?

https://codereview.chromium.org/2902253004/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/extensions/users_private/users_private_api.cc:219:
&UsersPrivateIsCurrentUserOwnerFunction::IsOwnerCallback, this));
On 2017/05/25 23:57:32, stevenjb wrote:
> Unfortunately this never responds in the apitest (browser_tests
> --gtest_filter=*UsersPrivete*Owner). Is there an easy way to ensure this will
> respond in a test?

Think the easiest way is to mock an owner key pair. I have created
https://codereview.chromium.org/2905203003/ fyi. #2 is the delta that mocks an
owner key and seems IsOwner test is happy with that.

[stevenjb, 2017-05-26 19:44:47]

https://codereview.chromium.org/2902253004/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/extensions/users_private/users_private_api.cc
(right):

https://codereview.chromium.org/2902253004/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/extensions/users_private/users_private_api.cc:27:
#include "components/ownership/owner_settings_service.h"
On 2017/05/26 16:21:37, xiyuan wrote:
> nit: Do we need this since we have the owner_settings_service_chromeos.h
> included already ?

Done.

https://codereview.chromium.org/2902253004/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/extensions/users_private/users_private_api.cc:219:
&UsersPrivateIsCurrentUserOwnerFunction::IsOwnerCallback, this));
On 2017/05/26 16:21:37, xiyuan wrote:
> On 2017/05/25 23:57:32, stevenjb wrote:
> > Unfortunately this never responds in the apitest (browser_tests
> > --gtest_filter=*UsersPrivete*Owner). Is there an easy way to ensure this
will
> > respond in a test?
> 
> Think the easiest way is to mock an owner key pair. I have created
> https://codereview.chromium.org/2905203003/ fyi. #2 is the delta that mocks an
> owner key and seems IsOwner test is happy with that.

Thanks a ton, that would have been a lot harder for me to figure out! Added to
this CL.

[stevenjb, 2017-05-26 19:44:51]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2017-05-26 19:44:51]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/2902253004/#ps40001
(title: "Fix test")

[commit-bot: I haz the power, 2017-05-26 19:45:38]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 19:53:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 19:53:20]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_headless_rel on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[stevenjb, 2017-05-30 17:02:22]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2017-05-30 17:02:53]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 17:42:51]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496163742904280,
"parent_rev": "99b481419897f642644932ecab1db0ee7453147e", "commit_rev":
"08449a9d4ce38aeb0c5e0519e1f09fc1de1a42a0"}

[commit-bot: I haz the power, 2017-05-30 17:43:01]

Description was changed from

==========
Settings: Users: Make isCurrentUserOwner async

BUG=724421
==========

to

==========
Settings: Users: Make isCurrentUserOwner async

BUG=724421

Review-Url: https://codereview.chromium.org/2902253004
Cr-Commit-Position: refs/heads/master@{#475584}
Committed:
https://chromium.googlesource.com/chromium/src/+/08449a9d4ce38aeb0c5e0519e1f0...
==========

[commit-bot: I haz the power, 2017-05-30 17:43:04]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/08449a9d4ce38aeb0c5e0519e1f0...