Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2902203002: [Mojo Video Capture] Hook up connection lost events (Closed)

Created:
3 years, 7 months ago by chfremer
Modified:
3 years, 6 months ago
Reviewers:
emircan, mcasas, miu
CC:
chromium-reviews, posciak+watch_chromium.org, chfremer+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, xjz+watch_chromium.org, mfoltz+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mojo Video Capture] Hook up connection lost events This CL is part of the Mojo Video Capture work. For the bigger picture, see [1] CL26 Pass a callback into ServiceLaunchedVideoCaptureDevice that gets invoked when the connection to the video capture service is lost. The connection lost signal is passed through the VideoCaptureController to the VideoCaptureManager. Additional change: Uninitialize VideoCaptureProvider when the last client disconnects. This is to allow the service to shut down when it is no longer in use. BUG=584797 TEST= content_unittests --gtest_filter="*Video*" content_browsertests --gtest_filter="VideoCaptureBrowserTest.*" [1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing Review-Url: https://codereview.chromium.org/2902203002 Cr-Commit-Position: refs/heads/master@{#476469} Committed: https://chromium.googlesource.com/chromium/src/+/4186535f976a6ce2d1785d87e1f200419928164b

Patch Set 1 #

Total comments: 4

Patch Set 2 : Incorporate suggestions from PS1 #

Patch Set 3 : Fix duplicate member introduced during merging #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -32 lines) Patch
M content/browser/renderer_host/media/in_process_video_capture_device_launcher.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/media/in_process_video_capture_device_launcher.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/media/mock_video_capture_provider.h View 2 chunks +5 lines, -3 lines 0 comments Download
M content/browser/renderer_host/media/service_launched_video_capture_device.h View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/renderer_host/media/service_launched_video_capture_device.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M content/browser/renderer_host/media/service_video_capture_device_launcher.h View 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/media/service_video_capture_device_launcher.cc View 6 chunks +9 lines, -5 lines 0 comments Download
M content/browser/renderer_host/media/service_video_capture_device_launcher_unittest.cc View 1 9 chunks +75 lines, -11 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_controller.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_controller.cc View 2 chunks +13 lines, -4 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_device_launch_observer.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_manager.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_provider.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_provider_switcher.cc View 3 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 23 (16 generated)
chfremer
emircan@: PTAL mcasas@, miu@: FYI
3 years, 7 months ago (2017-05-24 17:02:45 UTC) #4
emircan
lgtm % nits. https://codereview.chromium.org/2902203002/diff/1/content/browser/renderer_host/media/service_video_capture_device_launcher_unittest.cc File content/browser/renderer_host/media/service_video_capture_device_launcher_unittest.cc (right): https://codereview.chromium.org/2902203002/diff/1/content/browser/renderer_host/media/service_video_capture_device_launcher_unittest.cc#newcode82 content/browser/renderer_host/media/service_video_capture_device_launcher_unittest.cc:82: base::MockCallback<base::OnceClosure> connection_lost_cb; s/connection_lost_cb/connection_lost_cb_ https://codereview.chromium.org/2902203002/diff/1/content/browser/renderer_host/media/service_video_capture_device_launcher_unittest.cc#newcode83 content/browser/renderer_host/media/service_video_capture_device_launcher_unittest.cc:83: base::MockCallback<base::OnceClosure> ...
3 years, 6 months ago (2017-06-01 18:13:29 UTC) #7
chfremer
Thanks for the review! https://codereview.chromium.org/2902203002/diff/1/content/browser/renderer_host/media/service_video_capture_device_launcher_unittest.cc File content/browser/renderer_host/media/service_video_capture_device_launcher_unittest.cc (right): https://codereview.chromium.org/2902203002/diff/1/content/browser/renderer_host/media/service_video_capture_device_launcher_unittest.cc#newcode82 content/browser/renderer_host/media/service_video_capture_device_launcher_unittest.cc:82: base::MockCallback<base::OnceClosure> connection_lost_cb; On 2017/06/01 18:13:29, ...
3 years, 6 months ago (2017-06-01 19:25:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2902203002/20001
3 years, 6 months ago (2017-06-01 19:26:48 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/459351) win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, ...
3 years, 6 months ago (2017-06-01 20:04:50 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2902203002/40001
3 years, 6 months ago (2017-06-01 23:00:39 UTC) #20
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 23:04:47 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/4186535f976a6ce2d1785d87e1f2...

Powered by Google App Engine
This is Rietveld 408576698