Updated negative-counts histogram for changes in logged/unlogged accounting.

Updated negative-counts histogram for changes in logged/unlogged accounting.

Histograms now keep an "logged" and "unlogged" instead of "total" and
"logged" so the calls to AddSubtractImpl no longer mean the same things
and can no longer be used to detect negative uploads to the server.

Move the counter to the Accumulate method to see if there are bad
calls being made.

BUG=682680
Review-Url: https://codereview.chromium.org/2902173002
Cr-Commit-Position: refs/heads/master@{#474362}
Committed: https://chromium.googlesource.com/chromium/src/+/ba6281e4333f2faeedff5a9d10e96a24e6b91fa4

[bcwhite, 2017-05-24 15:11:56]

The CQ bit was checked by bcwhite@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 15:12:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bcwhite, 2017-05-24 16:04:46]

bcwhite@chromium.org changed reviewers:
+ asvitkine@chromium.org

[Alexei Svitkine (slow), 2017-05-24 16:14:20]

lgtm

[commit-bot: I haz the power, 2017-05-24 16:29:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 16:29:51]

Dry run: This issue passed the CQ dry run.

[bcwhite, 2017-05-24 16:41:06]

The CQ bit was checked by bcwhite@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 16:41:52]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 18:14:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 18:14:21]

Dry run: This issue passed the CQ dry run.

[bcwhite, 2017-05-24 18:23:49]

The CQ bit was checked by bcwhite@chromium.org

[bcwhite, 2017-05-24 18:23:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/2902173002/#ps20001
(title: "rebased")

[commit-bot: I haz the power, 2017-05-24 18:24:33]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 18:29:52]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495650229479600,
"parent_rev": "d8955f1c68c20bc97db9d800be8a13bcc6631b38", "commit_rev":
"ba6281e4333f2faeedff5a9d10e96a24e6b91fa4"}

[commit-bot: I haz the power, 2017-05-24 18:30:05]

Description was changed from

==========
Updated negative-counts histogram for changes in logged/unlogged accounting.

Histograms now keep an "logged" and "unlogged" instead of "total" and
"logged" so the calls to AddSubtractImpl no longer mean the same things
and can no longer be used to detect negative uploads to the server.

Move the counter to the Accumulate method to see if there are bad
calls being made.

BUG=682680
==========

to

==========
Updated negative-counts histogram for changes in logged/unlogged accounting.

Histograms now keep an "logged" and "unlogged" instead of "total" and
"logged" so the calls to AddSubtractImpl no longer mean the same things
and can no longer be used to detect negative uploads to the server.

Move the counter to the Accumulate method to see if there are bad
calls being made.

BUG=682680

Review-Url: https://codereview.chromium.org/2902173002
Cr-Commit-Position: refs/heads/master@{#474362}
Committed:
https://chromium.googlesource.com/chromium/src/+/ba6281e4333f2faeedff5a9d10e9...
==========

[commit-bot: I haz the power, 2017-05-24 18:30:09]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ba6281e4333f2faeedff5a9d10e9...