Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2902133002: Revert of "Implement the inert attribute" (Closed)

Created:
3 years, 7 months ago by vitaliii
Modified:
3 years, 7 months ago
CC:
chromium-reviews, eae+blinkwatch, dougt+watch_chromium.org, apavlov+blink_chromium.org, dmazzoni+watch_chromium.org, kinuko+watch, rwlbuis, caseq+blink_chromium.org, aboxhall, aboxhall+watch_chromium.org, blink-reviews-html_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, je_julie, devtools-reviews_chromium.org, blink-reviews, blink-reviews-w3ctests_chromium.org, sof, yuzo+watch_chromium.org, dmazzoni, lushnikov+blink_chromium.org, asvitkine+watch_chromium.org, haraken, nektar+watch_chromium.org, pfeldman+blink_chromium.org, nektarios, dtseng+watch_chromium.org, blink-reviews-frames_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of "Implement the inert attribute" The revert did not apply cleanly, there were conflicts in: - third_party/WebKit/Source/core/frame/UseCounter.h - tools/metrics/histograms/enums.xml Reason for revert: The new added tests leak. See crbug.com/725815. Original issue's description: > Implement the inert attribute: https://github.com/WICG/inert#tldr > > https://discourse.wicg.io/t/inert-attribute/1838/ > > BUG=692360 > Review-Url: https://codereview.chromium.org/2088453002 > Cr-Commit-Position: refs/heads/master@{#474153} > Committed: https://chromium.googlesource.com/chromium/src/+/cca67d31f4a0b4ec2c20090a8bfc38c464274ab2 TBR=aboxhall@chromium.org,hayato@chromium.org,dglazkov@chromium.org,esprehn@chromium.org,dmazzoni@chromium.org,kochi@chromium.org BUG=692360, 725815 Review-Url: https://codereview.chromium.org/2902133002 Cr-Commit-Position: refs/heads/master@{#474259} Committed: https://chromium.googlesource.com/chromium/src/+/e353755ef5c7e109ddf2370ebacc39377924fc55

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -937 lines) Patch
M third_party/WebKit/LayoutTests/external/wpt/html/dom/elements/elements-in-the-dom/historical.html View 1 chunk +2 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/inert/inert-does-not-match-disabled-selector.html View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/inert/inert-focus-in-frames.html View 1 chunk +0 lines, -55 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/inert/inert-in-shadow-dom.html View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/inert/inert-inlines.html View 1 chunk +0 lines, -74 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/inert/inert-label-focus.html View 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/inert/inert-node-is-uneditable.html View 1 chunk +0 lines, -60 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/inert/inert-node-is-unfocusable.html View 1 chunk +0 lines, -76 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/inert/inert-node-is-unselectable.html View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/inert/resources/dialog-layout.css View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/inert/resources/inert-focus-in-frames-frame1.html View 1 chunk +0 lines, -21 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-ignoredNodes.html View 1 chunk +1 line, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-ignoredNodes-expected.txt View 6 chunks +6 lines, -107 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/inspector-protocol/accessibility/accessibility-ignoredNodes-expected.txt View 6 chunks +6 lines, -107 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/win/inspector-protocol/accessibility/accessibility-ignoredNodes-expected.txt View 6 chunks +6 lines, -107 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.h View 1 chunk +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 2 chunks +3 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Text.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLAttributeNames.json5 View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLElement.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityNodeView.js View 2 chunks +3 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXMenuListOption.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXMenuListOption.cpp View 2 chunks +0 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.h View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObjectImpl.h View 3 chunks +4 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObjectImpl.cpp View 4 chunks +6 lines, -50 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.h View 2 chunks +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp View 5 chunks +12 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.cpp View 5 chunks +11 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/metrics/histograms/enums.xml View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2902133002/1
3 years, 7 months ago (2017-05-24 11:43:15 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 12:23:07 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e353755ef5c7e109ddf2370ebacc...

Powered by Google App Engine
This is Rietveld 408576698