arc: Message for a low-battery case of migration notification.

arc: Message for a low-battery case of migration notification.

BUG=710289
TEST=Manually run on 29% and 31% battery devices.

Review-Url: https://codereview.chromium.org/2902093003
Cr-Commit-Position: refs/heads/master@{#474483}
Committed: https://chromium.googlesource.com/chromium/src/+/eda5652c60377024288d24f9ebc02b42619ebe9d

[kinaba, 2017-05-24 07:52:54]

kinaba@chromium.org changed reviewers:
+ fukino@chromium.org, hidehiko@chromium.org, xiyuan@chromium.org

[kinaba, 2017-05-24 07:52:55]

PTAL.
hidehiko@ : whole the change
fukino@ : On the renaming in encryption_migration_screen_handler.cc
xiyuan@ : As an OWNER of encryption_migration_screen_handler.cc

[kinaba, 2017-05-24 07:52:56]

The CQ bit was checked by kinaba@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 07:53:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fukino, 2017-05-24 08:15:32]

lgtm with a nit.

https://codereview.chromium.org/2902093003/diff/1/chrome/browser/ui/webui/chr...
File
chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc
(right):

https://codereview.chromium.org/2902093003/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc:46:
constexpr int64_t kMinimumAvailableStorage = 10LL * 1024 * 1024;  // 10MB
optional nit: Maybe we should move kMinimumAvailableStorage to
arc_migration_constants.h, too?

[commit-bot: I haz the power, 2017-05-24 09:03:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 09:03:20]

Dry run: This issue passed the CQ dry run.

[xiyuan, 2017-05-24 17:40:20]

lgtm

[hidehiko, 2017-05-24 17:50:02]

lgtm

[kinaba, 2017-05-24 21:58:06]

https://codereview.chromium.org/2902093003/diff/1/chrome/browser/ui/webui/chr...
File
chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc
(right):

https://codereview.chromium.org/2902093003/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc:46:
constexpr int64_t kMinimumAvailableStorage = 10LL * 1024 * 1024;  // 10MB
On 2017/05/24 08:15:32, fukino wrote:
> optional nit: Maybe we should move kMinimumAvailableStorage to
> arc_migration_constants.h, too?

Done.

[kinaba, 2017-05-24 21:58:24]

The CQ bit was checked by kinaba@chromium.org

[kinaba, 2017-05-24 21:58:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
hidehiko@chromium.org, xiyuan@chromium.org, fukino@chromium.org
Link to the patchset: https://codereview.chromium.org/2902093003/#ps20001
(title: "Move more constants to the dedicated header.")

[kinaba, 2017-05-24 21:58:37]

The CQ bit was unchecked by kinaba@chromium.org

[kinaba, 2017-05-24 22:00:23]

The CQ bit was checked by kinaba@chromium.org

[kinaba, 2017-05-24 22:00:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
hidehiko@chromium.org, xiyuan@chromium.org, fukino@chromium.org
Link to the patchset: https://codereview.chromium.org/2902093003/#ps40001
(title: "Fix typo")

[commit-bot: I haz the power, 2017-05-24 22:01:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 00:02:16]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495663223262660,
"parent_rev": "49faaf4047298f4a38df6347704d3fc7e2037539", "commit_rev":
"eda5652c60377024288d24f9ebc02b42619ebe9d"}

[commit-bot: I haz the power, 2017-05-25 00:02:27]

Description was changed from

==========
arc: Message for a low-battery case of migration notification.

BUG=710289
TEST=Manually run on 29% and 31% battery devices.
==========

to

==========
arc: Message for a low-battery case of migration notification.

BUG=710289
TEST=Manually run on 29% and 31% battery devices.

Review-Url: https://codereview.chromium.org/2902093003
Cr-Commit-Position: refs/heads/master@{#474483}
Committed:
https://chromium.googlesource.com/chromium/src/+/eda5652c60377024288d24f9ebc0...
==========

[commit-bot: I haz the power, 2017-05-25 00:02:28]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/eda5652c60377024288d24f9ebc0...