[EasyUnlock] Force user to enter their password after 20 hours.

[EasyUnlock] Force user to enter their password after 20 hours.

In a future CL, we will to put this password reauth mechanism behind an
enterprise policy. This behaviour should not be enabled by default.

BUG=724717
Review-Url: https://codereview.chromium.org/2902093002
Cr-Commit-Position: refs/heads/master@{#474519}
Committed: https://chromium.googlesource.com/chromium/src/+/fbddf800534d8daaeb12c31999fd85228cfd1685

[Tim Song, 2017-05-24 06:25:18]

Patchset #1 (id:1) has been deleted

[Tim Song, 2017-05-24 06:25:30]

tengs@chromium.org changed reviewers:
+ sacomoto@chromium.org

[sacomoto, 2017-05-24 17:35:21]

https://codereview.chromium.org/2902093002/diff/40001/chrome/browser/signin/e...
File chrome/browser/signin/easy_unlock_service_regular.cc (right):

https://codereview.chromium.org/2902093002/diff/40001/chrome/browser/signin/e...
chrome/browser/signin/easy_unlock_service_regular.cc:532:
proximity_auth::switches::kEnableChromeOSLogin))) {
Why do you care about the kEnableChromeOSLogin switch? Shouldn't we record the
timestamp even if the EasyUnlock login is enable?

[Tim Song, 2017-05-24 18:00:12]

https://codereview.chromium.org/2902093002/diff/40001/chrome/browser/signin/e...
File chrome/browser/signin/easy_unlock_service_regular.cc (right):

https://codereview.chromium.org/2902093002/diff/40001/chrome/browser/signin/e...
chrome/browser/signin/easy_unlock_service_regular.cc:532:
proximity_auth::switches::kEnableChromeOSLogin))) {
On 2017/05/24 17:35:21, sacomoto wrote:
> Why do you care about the kEnableChromeOSLogin switch? Shouldn't we record the
> timestamp even if the EasyUnlock login is enable?

The login logic is handled by EasyUnlockServiceSignInChromeOS, so we don't know
if the login was done by a password or by EasyUnlock here. It's simply easier
for now to ignore the login case for now and assume all logins are done by
passwords.

[sacomoto, 2017-05-24 18:02:52]

lgtm

[Tim Song, 2017-05-24 18:05:20]

The CQ bit was checked by tengs@chromium.org

[commit-bot: I haz the power, 2017-05-24 18:06:04]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 18:16:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 18:16:17]

Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Tim Song, 2017-05-24 22:52:36]

The CQ bit was checked by tengs@chromium.org

[Tim Song, 2017-05-24 22:52:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
sacomoto@chromium.org
Link to the patchset: https://codereview.chromium.org/2902093002/#ps60001
(title: "update unit test")

[commit-bot: I haz the power, 2017-05-24 22:53:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 23:23:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 23:23:24]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Tim Song, 2017-05-24 23:41:27]

The CQ bit was checked by tengs@chromium.org

[Tim Song, 2017-05-24 23:41:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
sacomoto@chromium.org
Link to the patchset: https://codereview.chromium.org/2902093002/#ps80001
(title: "fix test")

[commit-bot: I haz the power, 2017-05-24 23:42:33]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 01:55:44]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1495669287855970,
"parent_rev": "eaac775e842c8a7289139e1702c0163cdb7d7908", "commit_rev":
"fbddf800534d8daaeb12c31999fd85228cfd1685"}

[commit-bot: I haz the power, 2017-05-25 01:55:56]

Description was changed from

==========
[EasyUnlock] Force user to enter their password after 20 hours.

In a future CL, we will to put this password reauth mechanism behind an
enterprise policy. This behaviour should not be enabled by default.

BUG=724717
==========

to

==========
[EasyUnlock] Force user to enter their password after 20 hours.

In a future CL, we will to put this password reauth mechanism behind an
enterprise policy. This behaviour should not be enabled by default.

BUG=724717

Review-Url: https://codereview.chromium.org/2902093002
Cr-Commit-Position: refs/heads/master@{#474519}
Committed:
https://chromium.googlesource.com/chromium/src/+/fbddf800534d8daaeb12c31999fd...
==========

[commit-bot: I haz the power, 2017-05-25 01:55:57]

Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/fbddf800534d8daaeb12c31999fd...