Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2902083003: Fixed Navigation callbacks for reloading native context. (Closed)

Created:
3 years, 7 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 7 months ago
Reviewers:
kkhorimoto
CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed Navigation callbacks for reloading native context. Notable changes: - DidStartNavigation, DidFinishNavigation is now called - PageTransition is updated to PAGE_TRANSITION_RELOAD - DidStartLoading, DidStopLoading is now called - PageLoaded(SUCCESS) is now called The primary reason for this change is to fix PageTransition, which will allow replacing -[CRWWebDelegate webWillReload] with DidStartNavigation. BUG=725985 Review-Url: https://codereview.chromium.org/2902083003 Cr-Commit-Position: refs/heads/master@{#474416} Committed: https://chromium.googlesource.com/chromium/src/+/f073ae8c53e657b2dbbd1387f747d79cacefc71c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -1 line) Patch
M ios/web/web_state/navigation_callbacks_inttest.mm View 2 chunks +55 lines, -0 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
Eugene But (OOO till 7-30)
3 years, 7 months ago (2017-05-24 18:30:27 UTC) #6
kkhorimoto
lgtm
3 years, 7 months ago (2017-05-24 20:38:37 UTC) #7
Eugene But (OOO till 7-30)
Thanks for a quick review!
3 years, 7 months ago (2017-05-24 20:48:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2902083003/1
3 years, 7 months ago (2017-05-24 20:49:30 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 20:55:18 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f073ae8c53e657b2dbbd1387f747...

Powered by Google App Engine
This is Rietveld 408576698