Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 2902043007: allocator: rename use_experimental_allocator_shim to use_allocator_shim (Closed)

Created:
3 years, 7 months ago by Primiano Tucci (use gerrit)
Modified:
3 years, 7 months ago
CC:
chromium-reviews, Dirk Pranke, Dai Mikurube (NOT FULLTIME), vmpstr+watch_chromium.org, wfh+watch_chromium.org, agrieve+watch_chromium.org, mac-reviews_chromium.org, tracing+reviews_chromium.org, danakj+watch_chromium.org, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

allocator: rename use_experimental_allocator_shim to use_allocator_shim This is a pure buildflag renaming with no intended functional changes. The allocator shim has been stably shipped to various stable versions on Windows, Linux, Android, CrOS and Mac OS, hence is not experimental anymore. BUG=550886 TBR=rockot Review-Url: https://codereview.chromium.org/2902043007 Cr-Commit-Position: refs/heads/master@{#474655} Committed: https://chromium.googlesource.com/chromium/src/+/73228cd43d2e9794bab5a8508c5db4b23704bc84

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -46 lines) Patch
M base/BUILD.gn View 3 chunks +3 lines, -5 lines 0 comments Download
M base/allocator/BUILD.gn View 4 chunks +5 lines, -5 lines 0 comments Download
M base/allocator/README.md View 2 chunks +4 lines, -3 lines 0 comments Download
M base/allocator/allocator_shim_override_glibc_weak_symbols.h View 1 chunk +1 line, -1 line 0 comments Download
M base/allocator/allocator_shim_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/debug/thread_heap_usage_tracker.h View 1 chunk +1 line, -1 line 0 comments Download
M base/debug/thread_heap_usage_tracker.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M base/debug/thread_heap_usage_tracker_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/process/memory_linux.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M base/process/memory_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M base/process/memory_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M base/trace_event/malloc_dump_provider.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M build/config/allocator.gni View 3 chunks +8 lines, -9 lines 0 comments Download
M services/service_manager/embedder/main.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/gn/bootstrap/bootstrap.py View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 21 (13 generated)
Primiano Tucci (use gerrit)
thakis PTAL, this is just a rename and no functional change (if I did everything ...
3 years, 7 months ago (2017-05-25 11:06:25 UTC) #5
Nico
lgtm
3 years, 7 months ago (2017-05-25 14:52:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2902043007/1
3 years, 7 months ago (2017-05-25 15:02:31 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/447438)
3 years, 7 months ago (2017-05-25 15:09:52 UTC) #12
Primiano Tucci (use gerrit)
For archaeological records, the old win shim is deleted separately in https://codereview.chromium.org/2907563002
3 years, 7 months ago (2017-05-25 15:10:10 UTC) #13
Primiano Tucci (use gerrit)
TBR rockot for 2 lines macro rename in services/service_manager/embedder/main.cc
3 years, 7 months ago (2017-05-25 15:11:30 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2902043007/1
3 years, 7 months ago (2017-05-25 15:11:58 UTC) #18
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 15:16:43 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/73228cd43d2e9794bab5a8508c5d...

Powered by Google App Engine
This is Rietveld 408576698