[Cleanup] Restore an enum association.

[Cleanup] Restore an enum association.

This is a partial revert of https://codereview.chromium.org/2885013004, which
removed the "DnsProbe.ObsoleteProbeResult" enum association. AFAICT there was no
need to remove it.

BUG=none
TEST='git cl format; git cl presubmit;'
R=chengx@chromium.org

Review-Url: https://codereview.chromium.org/2902043002
Cr-Commit-Position: refs/heads/master@{#474215}
Committed: https://chromium.googlesource.com/chromium/src/+/6596eab9f398dbdef4f03ab3101f27b9fe464bd9

[Ilya Sherman, 2017-05-23 22:05:18]

The CQ bit was checked by isherman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 22:06:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chengx, 2017-05-23 22:22:13]

Hi Ilya, have you run the python script
"c:\src\chromium\src\tools\metrics\histograms/pretty_print.py"?

Running this python script gives "ERROR:root:Unknown enum
DnsProbe.obsoleteProbeResult" on my machine.

[Ilya Sherman, 2017-05-23 22:49:18]

On 2017/05/23 22:22:13, chengx wrote:
> Hi Ilya, have you run the python script
> "c:\src\chromium\src\tools\metrics\histograms/pretty_print.py"?

Yes, here is the output:

$ ./tools/metrics/histograms/pretty_print.py
INFO:root:Loading tools/metrics/histograms/enums.xml...
INFO:root:enums.xml is correctly pretty-printed.
INFO:root:Loading tools/metrics/histograms/histograms.xml...
INFO:root:histograms.xml is correctly pretty-printed.

> Running this python script gives "ERROR:root:Unknown enum
> DnsProbe.obsoleteProbeResult" on my machine.

Why does the error show a lowercase 'o' as the first letter of 'obsolete'?  The
enum in histograms.xml has an uppercase 'o'.  Is this some sort of weird
encoding difference between Windows and Linux?  Do you still see the error if
you retype the enum name?

[chengx, 2017-05-23 23:06:05]

LGTM

On 2017/05/23 22:49:18, Ilya Sherman wrote:
> On 2017/05/23 22:22:13, chengx wrote:
> > Hi Ilya, have you run the python script
> > "c:\src\chromium\src\tools\metrics\histograms/pretty_print.py"?
> 
> Yes, here is the output:
> 
> $ ./tools/metrics/histograms/pretty_print.py
> INFO:root:Loading tools/metrics/histograms/enums.xml...
> INFO:root:enums.xml is correctly pretty-printed.
> INFO:root:Loading tools/metrics/histograms/histograms.xml...
> INFO:root:histograms.xml is correctly pretty-printed.

I just tried to add back DnsProbe.ObsoleteProbeResult and ran the script. It's
running good on my machine too. It was not yesterday though. Wired.

> > Running this python script gives "ERROR:root:Unknown enum
> > DnsProbe.obsoleteProbeResult" on my machine.
> 
> Why does the error show a lowercase 'o' as the first letter of 'obsolete'? 
The
> enum in histograms.xml has an uppercase 'o'.  Is this some sort of weird
> encoding difference between Windows and Linux?  Do you still see the error if
> you retype the enum name?

In short, it's not a problem. The lowercase 'o' was generated by me I think.
What happened is that I somehow replaced all 'Obsolete' with 'obsolete',
including the one in DnsProbe.ObsoleteProbeResult. Then I ran the python script
and it generated the lowercase 'o' in DnsProbe.ObsoleteProbeResult. Since I've
reverted those incorrect changes, this issue is gone already I believe.

[Ilya Sherman, 2017-05-23 23:30:49]

The CQ bit was unchecked by isherman@chromium.org

[Ilya Sherman, 2017-05-23 23:30:50]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2017-05-23 23:31:11]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 05:05:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 05:05:58]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ilya Sherman, 2017-05-24 05:45:10]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2017-05-24 05:45:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 08:35:27]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495604710249250, "parent_rev":
"345822a545e88721238d0fa9fe13a43acb5b5681", "commit_rev":
"6596eab9f398dbdef4f03ab3101f27b9fe464bd9"}

[commit-bot: I haz the power, 2017-05-24 08:35:40]

Description was changed from

==========
[Cleanup] Restore an enum association.

This is a partial revert of https://codereview.chromium.org/2885013004, which
removed the "DnsProbe.ObsoleteProbeResult" enum association. AFAICT there was no
need to remove it.

BUG=none
TEST='git cl format; git cl presubmit;'
R=chengx@chromium.org
==========

to

==========
[Cleanup] Restore an enum association.

This is a partial revert of https://codereview.chromium.org/2885013004, which
removed the "DnsProbe.ObsoleteProbeResult" enum association. AFAICT there was no
need to remove it.

BUG=none
TEST='git cl format; git cl presubmit;'
R=chengx@chromium.org

Review-Url: https://codereview.chromium.org/2902043002
Cr-Commit-Position: refs/heads/master@{#474215}
Committed:
https://chromium.googlesource.com/chromium/src/+/6596eab9f398dbdef4f03ab3101f...
==========

[commit-bot: I haz the power, 2017-05-24 08:35:41]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6596eab9f398dbdef4f03ab3101f...