Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2902033002: WebUI: Fix violations of no-extra-semi lint rule. (Closed)

Created:
3 years, 7 months ago by dpapad
Modified:
3 years, 7 months ago
Reviewers:
Dan Beam
CC:
aboxhall+watch_chromium.org, achuith+watch_chromium.org, alemate+watch_chromium.org, arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, dbeam+watch-options_chromium.org, dmazzoni+watch_chromium.org, dougt+watch_chromium.org, dtseng+watch_chromium.org, je_julie, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-options_chromium.org, michaelpg+watch-md-ui_chromium.org, nektar+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, pam+watch_chromium.org, shuchen+watch_chromium.org, stevenjb+watch-md-settings_chromium.org, tfarina, yusukes+watch_chromium.org, yuzo+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

WebUI: Fix violations of no-extra-semi lint rule. This is in preparation of enabling http://eslint.org/docs/rules/no-extra-semi check during PRESUBMIT. BUG=720034 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2902033002 Cr-Commit-Position: refs/heads/master@{#474342} Committed: https://chromium.googlesource.com/chromium/src/+/9de1000c0a7625e951a5a80303ab63d24b67542c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -28 lines) Patch
M chrome/browser/resources/chromeos/chromevox/chromevox/injected/api.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/injected/keyboard_handler.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/dom_util.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/screen_supervised_user_creation.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/switch_access/auto_scan_manager.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/switch_access/automation_manager.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/switch_access/automation_predicate.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/switch_access/keyboard_handler.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/switch_access/options.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/switch_access/prefs.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/switch_access/switch_access.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/switch_access/switch_access_interface.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/switch_access/test_support.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/switch_access/tree_walker.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/geolocation_options.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/language_list.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/startup_overlay.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/supervised_user_create_confirm.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/supervised_user_import.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/supervised_user_learn_more.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/supervised_user_list_data.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/prefs/prefs.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/site_settings/cookie_tree_node.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/js/cr/ui/alert_overlay.js View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/webui/resources/js/webui_resource_test.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (10 generated)
Dan Beam
lgtm this would've been very very hard to find with a regex-based parser ;) (IMO)
3 years, 7 months ago (2017-05-24 02:48:34 UTC) #6
dpapad
On 2017/05/24 at 02:48:34, dbeam wrote: > lgtm > > this would've been very very ...
3 years, 7 months ago (2017-05-24 17:36:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2902033002/1
3 years, 7 months ago (2017-05-24 17:38:04 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 17:45:35 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9de1000c0a7625e951a5a80303ab...

Powered by Google App Engine
This is Rietveld 408576698