Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 290203002: <picture>: Update the <img> element when a <source> changes (Closed)

Created:
6 years, 7 months ago by cbiesinger
Modified:
6 years, 7 months ago
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

<picture>: Update the <img> element when a <source> changes R=abarth@chromium.org CC=yoav@yoav.ws BUG=233751 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174731

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : with tests #

Total comments: 9

Patch Set 4 : review comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -6 lines) Patch
A LayoutTests/fast/dom/HTMLImageElement/image-picture-source-dynamic-changes.html View 1 2 1 chunk +54 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/HTMLImageElement/image-picture-source-dynamic-changes-expected.txt View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
M Source/core/html/HTMLImageElement.h View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/html/HTMLImageElement.cpp View 1 2 3 2 chunks +24 lines, -6 lines 0 comments Download
M Source/core/html/HTMLPictureElement.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/HTMLPictureElement.cpp View 1 2 3 2 chunks +9 lines, -0 lines 0 comments Download
M Source/core/html/HTMLSourceElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLSourceElement.cpp View 1 2 3 4 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
cbiesinger
6 years, 7 months ago (2014-05-16 18:55:04 UTC) #1
Yoav Weiss
You could probably add some tests by building off the CL in https://codereview.chromium.org/288033018/
6 years, 7 months ago (2014-05-19 10:29:28 UTC) #2
Yoav Weiss
On 2014/05/19 10:29:28, Yoav Weiss wrote: > You could probably add some tests by building ...
6 years, 7 months ago (2014-05-20 10:34:29 UTC) #3
cbiesinger
On 2014/05/20 10:34:29, Yoav Weiss wrote: > On 2014/05/19 10:29:28, Yoav Weiss wrote: > > ...
6 years, 7 months ago (2014-05-21 00:50:07 UTC) #4
cbiesinger
Adam - this now has a test and should be ready for review. https://codereview.chromium.org/290203002/diff/40001/LayoutTests/fast/dom/HTMLImageElement/image-picture-source-dynamic-changes.html File ...
6 years, 7 months ago (2014-05-23 01:35:53 UTC) #5
Yoav Weiss
A few nits, but all in all, LGTM. Adding esprehn and eseidel as reviewers since ...
6 years, 7 months ago (2014-05-23 07:39:16 UTC) #6
eseidel
lgtm
6 years, 7 months ago (2014-05-23 08:16:31 UTC) #7
cbiesinger
https://codereview.chromium.org/290203002/diff/40001/Source/core/html/HTMLImageElement.cpp File Source/core/html/HTMLImageElement.cpp (right): https://codereview.chromium.org/290203002/diff/40001/Source/core/html/HTMLImageElement.cpp#newcode541 Source/core/html/HTMLImageElement.cpp:541: void HTMLImageElement::selectSourceURL(bool ignorePreviousError) On 2014/05/23 07:39:17, Yoav Weiss wrote: ...
6 years, 7 months ago (2014-05-23 19:30:37 UTC) #8
cbiesinger
The CQ bit was checked by cbiesinger@chromium.org
6 years, 7 months ago (2014-05-23 19:30:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cbiesinger@chromium.org/290203002/60001
6 years, 7 months ago (2014-05-23 19:31:30 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-23 20:52:21 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-23 22:16:36 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/8996)
6 years, 7 months ago (2014-05-23 22:16:37 UTC) #13
cbiesinger
The CQ bit was checked by cbiesinger@chromium.org
6 years, 7 months ago (2014-05-23 22:34:24 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cbiesinger@chromium.org/290203002/60001
6 years, 7 months ago (2014-05-23 22:35:20 UTC) #15
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 23:19:53 UTC) #16
Message was sent while issue was closed.
Change committed as 174731

Powered by Google App Engine
This is Rietveld 408576698