<picture>: Update the <img> element when a <source> changes

Source/core/html/HTMLSourceElement.cpp

 /*
  * Copyright (C) 2007, 2008, 2010 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 11 matching lines @@
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "core/html/HTMLSourceElement.h"
 
 #include "HTMLNames.h"
 #include "core/events/EventSender.h"
 #include "core/html/HTMLMediaElement.h"
+#include "core/html/HTMLPictureElement.h"
 #include "platform/Logging.h"
 
 using namespace std;
 
 namespace WebCore {
 
 using namespace HTMLNames;
 
 static SourceEventSender& sourceErrorEventSender()
 {
@@ skipping 17 matching lines @@
 {
     sourceErrorEventSender().cancelEvent(this);
 }
 
 Node::InsertionNotificationRequest HTMLSourceElement::insertedInto(ContainerNode* insertionPoint)
 {
     HTMLElement::insertedInto(insertionPoint);
     Element* parent = parentElement();
     if (isHTMLMediaElement(parent))
         toHTMLMediaElement(parent)->sourceWasAdded(this);
+    if (isHTMLPictureElement(parent))
+        toHTMLPictureElement(parent)->sourceOrMediaChanged();
     return InsertionDone;
 }
 
 void HTMLSourceElement::removedFrom(ContainerNode* removalRoot)
 {
     Element* parent = parentElement();
     if (!parent && removalRoot->isElementNode())
         parent = toElement(removalRoot);
     if (isHTMLMediaElement(parent))
         toHTMLMediaElement(parent)->sourceWasRemoved(this);
+    if (isHTMLPictureElement(parent))
+        toHTMLPictureElement(parent)->sourceOrMediaChanged();
     HTMLElement::removedFrom(removalRoot);
+

[Yoav Weiss, 2014/05/23 07:39:17]

Why the extra newline?

[cbiesinger, 2014/05/23 19:30:37]

Done.

 }
 
 void HTMLSourceElement::setSrc(const String& url)
 {
     setAttribute(srcAttr, AtomicString(url));
 }
 
 const AtomicString& HTMLSourceElement::type() const
 {
     return getAttribute(typeAttr);
@@ skipping 21 matching lines @@
     ASSERT_UNUSED(eventSender, eventSender == &sourceErrorEventSender());
     WTF_LOG(Media, "HTMLSourceElement::dispatchPendingEvent - %p", this);
     dispatchEvent(Event::createCancelable(EventTypeNames::error));
 }
 
 bool HTMLSourceElement::isURLAttribute(const Attribute& attribute) const
 {
     return attribute.name() == srcAttr || HTMLElement::isURLAttribute(attribute);
 }
 
+void HTMLSourceElement::parseAttribute(const QualifiedName& name, const AtomicString& value)
+{
+    HTMLElement::parseAttribute(name, value);
+    if (name == srcsetAttr || name == sizesAttr || name == mediaAttr || name == typeAttr) {
+        Element* parent = parentElement();
+        if (isHTMLPictureElement(parent)) {
+            toHTMLPictureElement(parent)->sourceOrMediaChanged();
+        }

[Yoav Weiss, 2014/05/23 07:39:17]

No need for these braces

[cbiesinger, 2014/05/23 19:30:37]

Done.

+    }
 }
+
+}