Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2902023004: [EasyUnlock] Reduce RSSI threshold to -70. (Closed)

Created:
3 years, 7 months ago by Tim Song
Modified:
3 years, 7 months ago
Reviewers:
sacomoto
CC:
chromium-reviews, jlklein+watch-tether_chromium.org, tengs+watch-tether_chromium.org, hansberry+watch-tether_chromium.org, jhawkins+watch-tether_chromium.org, lesliewatkins+watch-tether_chromium.org, khorimoto+watch-tether_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[EasyUnlock] Reduce RSSI threshold to -70. Because we have a hardcoded, unconfigurable value, we should set the threshold to be on the conservative side. BUG=724715 Review-Url: https://codereview.chromium.org/2902023004 Cr-Commit-Position: refs/heads/master@{#474513} Committed: https://chromium.googlesource.com/chromium/src/+/7f9fada9b2e464e9229047ea801bb3a61ec03634

Patch Set 1 #

Patch Set 2 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M components/proximity_auth/proximity_monitor_impl.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M components/proximity_auth/proximity_monitor_impl_unittest.cc View 1 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
Tim Song
3 years, 7 months ago (2017-05-24 18:17:18 UTC) #2
sacomoto
lgtm
3 years, 7 months ago (2017-05-24 18:40:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2902023004/1
3 years, 7 months ago (2017-05-24 21:05:10 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/392365) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 7 months ago (2017-05-24 21:27:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2902023004/20001
3 years, 7 months ago (2017-05-24 23:34:34 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 01:35:55 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7f9fada9b2e464e9229047ea801b...

Powered by Google App Engine
This is Rietveld 408576698