Remove unused Lite Page fallback code

Remove unused Lite Page fallback code

Client-side fallback from Lite Pages to Lo-Fi will not be launched.
Instead fallback will be provided via the server by the updates to the
CPAT protocol.

BUG=725645
Review-Url: https://codereview.chromium.org/2902003002
Cr-Commit-Position: refs/heads/master@{#475695}
Committed: https://chromium.googlesource.com/chromium/src/+/78b07cc63dc1acfa4a6d94d10ce024d5139448d6

[megjablon, 2017-05-23 20:46:21]

The CQ bit was checked by megjablon@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 20:47:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[megjablon, 2017-05-23 20:49:03]

Description was changed from

==========
Remove unused Lite Page fallback code

Client-side fallback from Lite Pages to Lo-Fi will not be launched.
Instead fallback will be provided via the server by the updates to the
CPAT protocol.

BUG=701802
==========

to

==========
Remove unused Lite Page fallback code

Client-side fallback from Lite Pages to Lo-Fi will not be launched.
Instead fallback will be provided via the server by the updates to the
CPAT protocol.

BUG=725645
==========

[commit-bot: I haz the power, 2017-05-23 21:08:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 21:08:07]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[megjablon, 2017-05-23 22:12:46]

The CQ bit was checked by megjablon@chromium.org to run a CQ dry run

[megjablon, 2017-05-23 22:13:22]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-05-23 22:14:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[megjablon, 2017-05-23 23:31:17]

megjablon@chromium.org changed reviewers:
+ dougarnett@chromium.org, ryansturm@chromium.org

[commit-bot: I haz the power, 2017-05-24 04:59:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 04:59:48]

Dry run: This issue passed the CQ dry run.

[dougarnett, 2017-05-24 16:07:04]

https://codereview.chromium.org/2902003002/diff/20001/components/data_reducti...
File components/data_reduction_proxy/content/browser/content_lofi_decider.cc
(right):

https://codereview.chromium.org/2902003002/diff/20001/components/data_reducti...
components/data_reduction_proxy/content/browser/content_lofi_decider.cc:120: //
TODO(dougarnett): Remove this check for new CPAT header.
Curious for chromium - shouldn't the TODO(person) be the author of the TODO? 

In any event, I will not use this conditional for the new path (eg, will not be
checking any flags) so I suggest dropping this TODO.

[RyanSturm, 2017-05-24 16:12:20]

lgtm

https://codereview.chromium.org/2902003002/diff/20001/components/data_reducti...
File components/data_reduction_proxy/content/browser/content_lofi_decider.cc
(right):

https://codereview.chromium.org/2902003002/diff/20001/components/data_reducti...
components/data_reduction_proxy/content/browser/content_lofi_decider.cc:120: //
TODO(dougarnett): Remove this check for new CPAT header.
On 2017/05/24 16:07:04, dougarnett wrote:
> Curious for chromium - shouldn't the TODO(person) be the author of the TODO? 
> 
> In any event, I will not use this conditional for the new path (eg, will not
be
> checking any flags) so I suggest dropping this TODO.

I think this whole method should be re-written when CPAT gets updated, since I
think a lot of it is unncessary, but I'm not totally sure.

[dougarnett, 2017-05-24 16:15:33]

https://codereview.chromium.org/2902003002/diff/20001/components/data_reducti...
File components/data_reduction_proxy/content/browser/content_lofi_decider.cc
(right):

https://codereview.chromium.org/2902003002/diff/20001/components/data_reducti...
components/data_reduction_proxy/content/browser/content_lofi_decider.cc:120: //
TODO(dougarnett): Remove this check for new CPAT header.
On 2017/05/24 16:12:20, RyanSturm wrote:
> On 2017/05/24 16:07:04, dougarnett wrote:
> > Curious for chromium - shouldn't the TODO(person) be the author of the TODO?

> > 
> > In any event, I will not use this conditional for the new path (eg, will not
> be
> > checking any flags) so I suggest dropping this TODO.
> 
> I think this whole method should be re-written when CPAT gets updated, since I
> think a lot of it is unncessary, but I'm not totally sure.

Yeah, I have a CL already for it that is waiting on getting a preceding
ProxyConfig CL approved first.

[megjablon, 2017-05-30 17:49:24]

https://codereview.chromium.org/2902003002/diff/20001/components/data_reducti...
File components/data_reduction_proxy/content/browser/content_lofi_decider.cc
(right):

https://codereview.chromium.org/2902003002/diff/20001/components/data_reducti...
components/data_reduction_proxy/content/browser/content_lofi_decider.cc:120: //
TODO(dougarnett): Remove this check for new CPAT header.
On 2017/05/24 16:15:33, dougarnett wrote:
> On 2017/05/24 16:12:20, RyanSturm wrote:
> > On 2017/05/24 16:07:04, dougarnett wrote:
> > > Curious for chromium - shouldn't the TODO(person) be the author of the
TODO?
> 
> > > 
> > > In any event, I will not use this conditional for the new path (eg, will
not
> > be
> > > checking any flags) so I suggest dropping this TODO.
> > 
> > I think this whole method should be re-written when CPAT gets updated, since
I
> > think a lot of it is unncessary, but I'm not totally sure.
> 
> Yeah, I have a CL already for it that is waiting on getting a preceding
> ProxyConfig CL approved first.

Ok, removed. I just wanted to make sure it got removed with the new CPAT and
figured it didn't hurt to make a note of that.

[dougarnett, 2017-05-30 18:09:25]

lgtm

[megjablon, 2017-05-30 18:39:22]

The CQ bit was checked by megjablon@chromium.org

[megjablon, 2017-05-30 18:39:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
ryansturm@chromium.org
Link to the patchset: https://codereview.chromium.org/2902003002/#ps40001
(title: "remove TODO")

[commit-bot: I haz the power, 2017-05-30 18:39:57]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 18:42:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 18:42:30]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[megjablon, 2017-05-30 19:15:37]

The CQ bit was checked by megjablon@chromium.org

[megjablon, 2017-05-30 19:15:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
ryansturm@chromium.org, dougarnett@chromium.org
Link to the patchset: https://codereview.chromium.org/2902003002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2017-05-30 19:17:35]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 19:26:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 19:26:09]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_headless_rel on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[megjablon, 2017-05-30 19:27:42]

The CQ bit was checked by megjablon@chromium.org

[commit-bot: I haz the power, 2017-05-30 19:28:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 19:48:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 19:48:40]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[megjablon, 2017-05-30 22:10:21]

The CQ bit was checked by megjablon@chromium.org

[commit-bot: I haz the power, 2017-05-30 22:11:13]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 23:52:12]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1496182221500560,
"parent_rev": "3a2b4be52d3f11b216be38f9e5f2ca10962a4591", "commit_rev":
"78b07cc63dc1acfa4a6d94d10ce024d5139448d6"}

[commit-bot: I haz the power, 2017-05-30 23:52:21]

Description was changed from

==========
Remove unused Lite Page fallback code

Client-side fallback from Lite Pages to Lo-Fi will not be launched.
Instead fallback will be provided via the server by the updates to the
CPAT protocol.

BUG=725645
==========

to

==========
Remove unused Lite Page fallback code

Client-side fallback from Lite Pages to Lo-Fi will not be launched.
Instead fallback will be provided via the server by the updates to the
CPAT protocol.

BUG=725645

Review-Url: https://codereview.chromium.org/2902003002
Cr-Commit-Position: refs/heads/master@{#475695}
Committed:
https://chromium.googlesource.com/chromium/src/+/78b07cc63dc1acfa4a6d94d10ce0...
==========

[commit-bot: I haz the power, 2017-05-30 23:52:22]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/78b07cc63dc1acfa4a6d94d10ce0...