Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2901973002: [Mac] Mirror profile switcher UI in RTL (Closed)

Created:
3 years, 7 months ago by lgrey
Modified:
3 years, 7 months ago
Reviewers:
Elly Fong-Jones
CC:
chromium-reviews, jshin+watch_chromium.org, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Mirror profile switcher UI in RTL BUG=723730 Review-Url: https://codereview.chromium.org/2901973002 Cr-Commit-Position: refs/heads/master@{#474399} Committed: https://chromium.googlesource.com/chromium/src/+/e91e520f7b2f426b860955d9be2694a28b353866

Patch Set 1 #

Patch Set 2 : + supervised user badge #

Total comments: 2

Patch Set 3 : CL comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -46 lines) Patch
M chrome/browser/ui/cocoa/l10n_util.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/l10n_util.mm View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm View 1 2 20 chunks +72 lines, -46 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
lgrey
PTAL :)
3 years, 7 months ago (2017-05-24 18:25:12 UTC) #6
Elly Fong-Jones
lgtm https://codereview.chromium.org/2901973002/diff/20001/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm File chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm (right): https://codereview.chromium.org/2901973002/diff/20001/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm#newcode1655 chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm:1655: if (isRTL) multi-line if bodies need {}
3 years, 7 months ago (2017-05-24 18:55:27 UTC) #7
lgrey
Thanks! https://codereview.chromium.org/2901973002/diff/20001/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm File chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm (right): https://codereview.chromium.org/2901973002/diff/20001/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm#newcode1655 chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm:1655: if (isRTL) On 2017/05/24 18:55:27, Elly Fong-Jones wrote: ...
3 years, 7 months ago (2017-05-24 19:41:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2901973002/40001
3 years, 7 months ago (2017-05-24 19:42:04 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 20:01:09 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e91e520f7b2f426b860955d9be26...

Powered by Google App Engine
This is Rietveld 408576698