Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2901963002: Remove unused methods from common.system.User. (Closed)

Created:
3 years, 7 months ago by qyearsley
Modified:
3 years, 7 months ago
Reviewers:
jeffcarp
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused methods from common.system.User. Specifically: prompt_password prompt_with_multiple_lists edit page There are other fixes that could be made in the user module, but those can be done in other CLs. BUG=677561 Review-Url: https://codereview.chromium.org/2901963002 Cr-Commit-Position: refs/heads/master@{#474738} Committed: https://chromium.googlesource.com/chromium/src/+/078204ebbd6e30ba2ed6078cedeb0574e524d4fd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -72 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/user.py View 3 chunks +0 lines, -36 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/user_mock.py View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/user_unittest.py View 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
qyearsley
3 years, 7 months ago (2017-05-23 19:48:11 UTC) #2
qyearsley
Friendly ping :-)
3 years, 7 months ago (2017-05-25 17:41:46 UTC) #8
jeffcarp
lgtm
3 years, 7 months ago (2017-05-25 17:44:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2901963002/1
3 years, 7 months ago (2017-05-25 17:46:29 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 19:01:50 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/078204ebbd6e30ba2ed6078cedeb...

Powered by Google App Engine
This is Rietveld 408576698