Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2901923002:
Reduce string building complexity when needing to add a NUL byte (Closed)
|
Created:
3 years, 7 months ago by Peter Beverloo Modified:
3 years, 7 months ago Reviewers:
eroman CC:
chromium-reviews, Peter Beverloo, johnme+watch_chromium.org, zea+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionReduce string building complexity when needing to add a NUL byte
sizeof() enables us to copy over the NUL terminator included with the
string constant as well, so indicate the size explicitly.
BUG=679789
Review-Url: https://codereview.chromium.org/2901923002
Cr-Commit-Position: refs/heads/master@{#474247}
Committed: https://chromium.googlesource.com/chromium/src/+/01f5fe9f3bf0c8574a78037f7ac07d8bc2dceffc
Patch Set 1 : Reduce string building complexity when needing to add a NUL byte #
Total comments: 2
Patch Set 2 : Reduce string building complexity when needing to add a NUL byte #Patch Set 3 : rebase #Messages
Total messages: 16 (9 generated)
Patchset #1 (id:1) has been deleted
peter@chromium.org changed reviewers: + eroman@chromium.org
+eroman
lgtm https://codereview.chromium.org/2901923002/diff/20001/components/gcm_driver/c... File components/gcm_driver/crypto/gcm_message_cryptographer.cc (right): https://codereview.chromium.org/2901923002/diff/20001/components/gcm_driver/c... components/gcm_driver/crypto/gcm_message_cryptographer.cc:61: std::string info(kInfo, sizeof(kInfo)); How about using a StringPiece instead? (avoids copying; HKDF looks to take StringPiece input).
https://codereview.chromium.org/2901923002/diff/20001/components/gcm_driver/c... File components/gcm_driver/crypto/gcm_message_cryptographer.cc (right): https://codereview.chromium.org/2901923002/diff/20001/components/gcm_driver/c... components/gcm_driver/crypto/gcm_message_cryptographer.cc:61: std::string info(kInfo, sizeof(kInfo)); On 2017/05/23 18:20:08, eroman wrote: > How about using a StringPiece instead? (avoids copying; HKDF looks to take > StringPiece input). Done.
The CQ bit was checked by peter@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from eroman@chromium.org Link to the patchset: https://codereview.chromium.org/2901923002/#ps40001 (title: "Reduce string building complexity when needing to add a NUL byte")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...) android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...) android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...) android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...) android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...) cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...) cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by peter@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from eroman@chromium.org Link to the patchset: https://codereview.chromium.org/2901923002/#ps60001 (title: "rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495619932321690,
"parent_rev": "9148da4ab010a58d8ac6c0f2247cd9a06512d9ca", "commit_rev":
"01f5fe9f3bf0c8574a78037f7ac07d8bc2dceffc"}
Message was sent while issue was closed.
Description was changed from ========== Reduce string building complexity when needing to add a NUL byte sizeof() enables us to copy over the NUL terminator included with the string constant as well, so indicate the size explicitly. BUG=679789 ========== to ========== Reduce string building complexity when needing to add a NUL byte sizeof() enables us to copy over the NUL terminator included with the string constant as well, so indicate the size explicitly. BUG=679789 Review-Url: https://codereview.chromium.org/2901923002 Cr-Commit-Position: refs/heads/master@{#474247} Committed: https://chromium.googlesource.com/chromium/src/+/01f5fe9f3bf0c8574a78037f7ac0... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as https://chromium.googlesource.com/chromium/src/+/01f5fe9f3bf0c8574a78037f7ac0... |
