Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 2901843002: Remove obsolete ASSERT macros (Closed)

Created:
3 years, 7 months ago by pilgrim_google
Modified:
3 years, 7 months ago
Reviewers:
haraken, tkent
CC:
blink-reviews, chromium-reviews, kinuko+watch, jsbell
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove obsolete ASSERT macros BUG=596760 Review-Url: https://codereview.chromium.org/2901843002 Cr-Commit-Position: refs/heads/master@{#473932} Committed: https://chromium.googlesource.com/chromium/src/+/d465e31bd450870f7191218231b0180f163421bb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -17 lines) Patch
M third_party/WebKit/Source/platform/wtf/Assertions.h View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
pilgrim_google
3 years, 7 months ago (2017-05-23 14:24:11 UTC) #3
haraken
LGTM
3 years, 7 months ago (2017-05-23 14:38:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2901843002/1
3 years, 7 months ago (2017-05-23 15:04:16 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/d465e31bd450870f7191218231b0180f163421bb
3 years, 7 months ago (2017-05-23 16:28:46 UTC) #11
tkent
3 years, 7 months ago (2017-05-23 22:59:28 UTC) #12
Message was sent while issue was closed.
Cool!  Thank you for the effort.

Powered by Google App Engine
This is Rietveld 408576698