Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1300)

Unified Diff: net/quic/core/quic_framer.cc

Issue 2901773004: Landing Recent QUIC changes until May 20, 2017. (Closed)
Patch Set: Disable quic_restart_flag_quic_big_endian_connection_id_server until tests can be fixed. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_flow_controller_test.cc ('k') | net/quic/core/quic_framer_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_framer.cc
diff --git a/net/quic/core/quic_framer.cc b/net/quic/core/quic_framer.cc
index 7404ebb1624bac5d7c36c8e05ea834d5be008a8a..84337191eb72a27daa26fa9f736fcf503d7d8b67 100644
--- a/net/quic/core/quic_framer.cc
+++ b/net/quic/core/quic_framer.cc
@@ -655,9 +655,6 @@ bool QuicFramer::AppendPacketHeader(const QuicPacketHeader& header,
if (header.public_header.version_flag) {
public_flags |= PACKET_PUBLIC_FLAGS_VERSION;
}
- if (header.public_header.multipath_flag) {
- public_flags |= PACKET_PUBLIC_FLAGS_MULTIPATH;
- }
public_flags |=
GetPacketNumberFlags(header.public_header.packet_number_length)
@@ -774,19 +771,12 @@ bool QuicFramer::ProcessPublicHeader(QuicDataReader* reader,
return false;
}
- public_header->multipath_flag =
- (public_flags & PACKET_PUBLIC_FLAGS_MULTIPATH) != 0;
public_header->reset_flag = (public_flags & PACKET_PUBLIC_FLAGS_RST) != 0;
public_header->version_flag =
(public_flags & PACKET_PUBLIC_FLAGS_VERSION) != 0;
if (validate_flags_ && !public_header->version_flag &&
- public_flags > (FLAGS_quic_reloadable_flag_quic_remove_multipath_bit
- ? PACKET_PUBLIC_FLAGS_MAX_WITHOUT_MULTIPATH_FLAG
- : PACKET_PUBLIC_FLAGS_MAX)) {
- if (FLAGS_quic_reloadable_flag_quic_remove_multipath_bit) {
- QUIC_FLAG_COUNT_N(quic_reloadable_flag_quic_remove_multipath_bit, 1, 2);
- }
+ public_flags > PACKET_PUBLIC_FLAGS_MAX) {
set_detailed_error("Illegal public flags value.");
return false;
}
@@ -827,13 +817,7 @@ bool QuicFramer::ProcessPublicHeader(QuicDataReader* reader,
// If not, this raises an error.
last_version_tag_ = version_tag;
QuicVersion version = QuicTagToQuicVersion(version_tag);
- if (version == quic_version_ &&
- public_flags > (FLAGS_quic_reloadable_flag_quic_remove_multipath_bit
- ? PACKET_PUBLIC_FLAGS_MAX_WITHOUT_MULTIPATH_FLAG
- : PACKET_PUBLIC_FLAGS_MAX)) {
- if (FLAGS_quic_reloadable_flag_quic_remove_multipath_bit) {
- QUIC_FLAG_COUNT_N(quic_reloadable_flag_quic_remove_multipath_bit, 1, 2);
- }
+ if (version == quic_version_ && public_flags > PACKET_PUBLIC_FLAGS_MAX) {
set_detailed_error("Illegal public flags value.");
return false;
}
« no previous file with comments | « net/quic/core/quic_flow_controller_test.cc ('k') | net/quic/core/quic_framer_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698