Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2901773004: Landing Recent QUIC changes until May 20, 2017. (Closed)

Created:
3 years, 7 months ago by ianswett
Modified:
3 years, 7 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Landing Recent QUIC changes until May 20, 2017. Update flags. https://codereview.chromium.org/2901993002/ Replace the linked_hash_map used by the BandwidthSampler with a deque. Protected by FLAGS_quic_reloadable_flag_quic_faster_bandwidth_sampler. Merge internal change: 156575470 https://codereview.chromium.org/2901083003/ Deprecate disabled FLAGS_quic_reloadable_flag_quic_bbr_fix_conservation in the false state. Merge internal change: 156459199 https://codereview.chromium.org/2904673002/ Provide a const version of PacketNumberIndexedQueue<T>::GetEntry(). n/a (code not currently used) Merge internal change: 156439769 https://codereview.chromium.org/2901113002/ Deprecate FLAGS_quic_reloadable_flag_quic_flow_control_faster_autotune. Merge internal change: 156318776 https://codereview.chromium.org/2900143003/ Deprecate FLAGS_quic_reloadable_flag_quic_remove_multipath_bit. Merge internal change: 156222368 https://codereview.chromium.org/2898233002/ Move some method definitions from header file to .cc file in shared QUIC in order to comply with Chromium style guide. No behavior change. Merge internal change: 1560440 https://codereview.chromium.org/2903633002/16 R=rch@chromium.org BUG= Review-Url: https://codereview.chromium.org/2901773004 Cr-Commit-Position: refs/heads/master@{#474810} Committed: https://chromium.googlesource.com/chromium/src/+/df0fddfdeff05f9c06333741c4e713d4cd95bbe4

Patch Set 1 #

Patch Set 2 : Disable quic_restart_flag_quic_big_endian_connection_id_server until tests can be fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -197 lines) Patch
M net/quic/core/congestion_control/bandwidth_sampler.h View 3 chunks +18 lines, -0 lines 0 comments Download
M net/quic/core/congestion_control/bandwidth_sampler.cc View 7 chunks +63 lines, -4 lines 0 comments Download
M net/quic/core/congestion_control/bandwidth_sampler_test.cc View 4 chunks +13 lines, -6 lines 0 comments Download
M net/quic/core/congestion_control/bbr_sender.cc View 2 chunks +3 lines, -21 lines 0 comments Download
M net/quic/core/packet_number_indexed_queue.h View 5 chunks +19 lines, -4 lines 0 comments Download
M net/quic/core/packet_number_indexed_queue_test.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M net/quic/core/quic_connection.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M net/quic/core/quic_connection_test.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M net/quic/core/quic_flags_list.h View 1 4 chunks +4 lines, -13 lines 0 comments Download
M net/quic/core/quic_flow_controller.cc View 1 chunk +1 line, -3 lines 0 comments Download
M net/quic/core/quic_flow_controller_test.cc View 6 chunks +14 lines, -57 lines 0 comments Download
M net/quic/core/quic_framer.cc View 3 chunks +2 lines, -18 lines 0 comments Download
M net/quic/core/quic_framer_test.cc View 14 chunks +8 lines, -22 lines 0 comments Download
M net/quic/core/quic_packet_creator.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/core/quic_packets.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/quic/core/quic_packets.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/core/quic_types.h View 1 chunk +1 line, -12 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 4 chunks +6 lines, -18 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 4 chunks +30 lines, -1 line 0 comments Download

Messages

Total messages: 28 (20 generated)
ianswett
3 years, 7 months ago (2017-05-23 21:21:17 UTC) #1
Ryan Hamilton
lgtm
3 years, 7 months ago (2017-05-23 21:22:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2901773004/1
3 years, 7 months ago (2017-05-24 19:53:41 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/446585)
3 years, 7 months ago (2017-05-24 20:03:36 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2901773004/1
3 years, 7 months ago (2017-05-25 14:49:23 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/223408)
3 years, 7 months ago (2017-05-25 16:04:09 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2901773004/20001
3 years, 7 months ago (2017-05-25 19:25:38 UTC) #24
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 21:24:28 UTC) #28
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/df0fddfdeff05f9c06333741c4e7...

Powered by Google App Engine
This is Rietveld 408576698