Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Issue 2901763002: Revert of Remove uses of FontList::Derive*(..) in views payments dialogs. (Closed)

Created:
3 years, 7 months ago by cfroussios
Modified:
3 years, 7 months ago
Reviewers:
tapted
CC:
chrome-apps-syd-reviews_chromium.org, chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove uses of FontList::Derive*(..) in views payments dialogs. (patchset #4 id:60001 of https://codereview.chromium.org/2899653002/ ) Reason for revert: Breaks compilation see crbug.com/725407 Original issue's description: > Remove uses of FontList::Derive*(..) in views payments dialogs. > > FontList::Derive(..) is slow (typically requiring IPC with the font > server), has unpredictable results with special UI fonts on Mac, and > encourages use of magic numbers like "-1". > > Instead, use context and style constants from the Chrome typography > spec, where available. When an equivalent font is not available, use > ResourceBundle to avoid a behavior change in this CL. > > BUG=721834 > > Review-Url: https://codereview.chromium.org/2899653002 > Cr-Commit-Position: refs/heads/master@{#473764} > Committed: https://chromium.googlesource.com/chromium/src/+/424d27cceaba0271bc21e9c9b48a39e4d5a2b21f TBR=tapted@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=721834 Review-Url: https://codereview.chromium.org/2901763002 Cr-Commit-Position: refs/heads/master@{#473839} Committed: https://chromium.googlesource.com/chromium/src/+/ddc5e16ef9191ecf5f74c039ed8cebaf9390765b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -111 lines) Patch
M chrome/browser/ui/test/test_browser_dialog.h View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/ui/test/test_browser_dialog.cc View 3 chunks +9 lines, -32 lines 0 comments Download
M chrome/browser/ui/views/payments/editor_view_controller.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/payments/order_summary_view_controller.cc View 1 chunk +10 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/payments/payment_method_view_controller.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/payments/payment_request_browsertest.cc View 2 chunks +0 lines, -27 lines 0 comments Download
M chrome/browser/ui/views/payments/payment_request_views_util.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/payments/payment_request_views_util.cc View 7 chunks +23 lines, -24 lines 0 comments Download
M chrome/browser/ui/views/payments/payment_sheet_view_controller.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (6 generated)
cfroussios
Created Revert of Remove uses of FontList::Derive*(..) in views payments dialogs.
3 years, 7 months ago (2017-05-23 08:36:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2901763002/1
3 years, 7 months ago (2017-05-23 08:36:30 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 08:37:17 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ddc5e16ef9191ecf5f74c039ed8c...

Powered by Google App Engine
This is Rietveld 408576698