Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2901753002:
Make VDA::Config's converting constructor explicit (Closed)
|
Created:
3 years, 7 months ago by Chandan Modified:
3 years, 7 months ago CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionMake VDA::Config's converting constructor explicit
This CL makes VDA::Config's converting constructor
explicit to avoid implicit conversions.
BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2901753002
Cr-Commit-Position: refs/heads/master@{#475073}
Committed: https://chromium.googlesource.com/chromium/src/+/f8d975ed29b6f665d66b1e57736f788a1bcfe287
Patch Set 1 #
Total comments: 2
Patch Set 2 : removed comment #
Total comments: 2
Patch Set 3 : braces for multiline if #
Messages
Total messages: 28 (18 generated)
Description was changed from ========== Make VDA::Config's converting constructor explicit This CL makes VDA::Config's converting constructor explicit to avoid implicit conversions. BUG=None ========== to ========== Make VDA::Config's converting constructor explicit This CL makes VDA::Config's converting constructor explicit to avoid implicit conversions. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by c.padhi@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
c.padhi@samsung.com changed reviewers: + bbudge@chromium.org, sandersd@chromium.org, watk@chromium.org
PTAL. Thank you.
Thanks! https://codereview.chromium.org/2901753002/diff/1/media/video/video_decode_ac... File media/video/video_decode_accelerator.h (right): https://codereview.chromium.org/2901753002/diff/1/media/video/video_decode_ac... media/video/video_decode_accelerator.h:133: // Intentional converting constructor. Please delete this comment now
content/renderer/pepper lgtm
The CQ bit was checked by c.padhi@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
PTAL https://codereview.chromium.org/2901753002/diff/1/media/video/video_decode_ac... File media/video/video_decode_accelerator.h (right): https://codereview.chromium.org/2901753002/diff/1/media/video/video_decode_ac... media/video/video_decode_accelerator.h:133: // Intentional converting constructor. On 2017/05/23 17:13:40, watk wrote: > Please delete this comment now Done.
PTAL @ps2.
https://codereview.chromium.org/2901753002/diff/20001/content/renderer/pepper... File content/renderer/pepper/pepper_video_decoder_host.cc (right): https://codereview.chromium.org/2901753002/diff/20001/content/renderer/pepper... content/renderer/pepper/pepper_video_decoder_host.cc:506: this)) This needs braces now (multiline if). Or alternatively make a local config variable.
The CQ bit was checked by c.padhi@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
PTAL @ps3. Thank you. https://codereview.chromium.org/2901753002/diff/20001/content/renderer/pepper... File content/renderer/pepper/pepper_video_decoder_host.cc (right): https://codereview.chromium.org/2901753002/diff/20001/content/renderer/pepper... content/renderer/pepper/pepper_video_decoder_host.cc:506: this)) On 2017/05/25 19:02:12, watk wrote: > This needs braces now (multiline if). > > Or alternatively make a local config variable. Done.
lgtm, thanks
The CQ bit was checked by c.padhi@samsung.com
The patchset sent to the CQ was uploaded after l-g-t-m from bbudge@chromium.org Link to the patchset: https://codereview.chromium.org/2901753002/#ps40001 (title: "braces for multiline if")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495824364836120,
"parent_rev": "60203e582cbbd603251a0ff6c0dd4f26d1a4a5b6", "commit_rev":
"f8d975ed29b6f665d66b1e57736f788a1bcfe287"}
Message was sent while issue was closed.
Description was changed from ========== Make VDA::Config's converting constructor explicit This CL makes VDA::Config's converting constructor explicit to avoid implicit conversions. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Make VDA::Config's converting constructor explicit This CL makes VDA::Config's converting constructor explicit to avoid implicit conversions. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2901753002 Cr-Commit-Position: refs/heads/master@{#475073} Committed: https://chromium.googlesource.com/chromium/src/+/f8d975ed29b6f665d66b1e57736f... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/f8d975ed29b6f665d66b1e57736f... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
