Bootstrapping: Reboot on enrollment failure

Bootstrapping: Reboot on enrollment failure

Add MESSAGE_REBOOT to ProtoDecoder. If host (slave device) enrollment 
status received by the controller (master device) is 
ENROLLMENT_STATUS_FAILURE. The controller can send MESSAGE_REBOOT to 
the host to notify the host to reboot. The host would be re-discovered
by the controller after the reboot to restart the enrollment process.
So that the host device can be enrolled successfully without user
interaction.

BUG=720719
Review-Url: https://codereview.chromium.org/2901653002
Cr-Commit-Position: refs/heads/master@{#474486}
Committed: https://chromium.googlesource.com/chromium/src/+/617dcc23c266b0b3c50fdb58052fdc6818e6b06b

[minch1, 2017-05-22 22:38:42]

The CQ bit was checked by minch@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 22:39:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 23:09:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 23:09:49]

Dry run: This issue passed the CQ dry run.

[minch1, 2017-05-22 23:11:17]

Description was changed from

==========
Reboot the host if enrollment fails.

BUG=720774
==========

to

==========
Reboot the host if enrollment fails.

BUG=720774
==========

[minch1, 2017-05-22 23:11:17]

minch@chromium.org changed reviewers:
+ xdai@chromium.org

[minch1, 2017-05-22 23:13:16]

xdai@, could you help review? Thanks.

[xdai1, 2017-05-23 00:07:50]

I think the CL's description is inaccurate. Could you update it?

https://codereview.chromium.org/2901653002/diff/1/components/pairing/pairing_...
File components/pairing/pairing_api.proto (right):

https://codereview.chromium.org/2901653002/diff/1/components/pairing/pairing_...
components/pairing/pairing_api.proto:102: optional int32 api_version = 1;
Can we have add a variable: optional bool reboot = 2 [default = true];

https://codereview.chromium.org/2901653002/diff/1/components/pairing/proto_de...
File components/pairing/proto_decoder.cc (right):

https://codereview.chromium.org/2901653002/diff/1/components/pairing/proto_de...
components/pairing/proto_decoder.cc:116: case MESSAGE_REBOOT: {
the indent is off

[minch1, 2017-05-23 00:15:47]

Description was changed from

==========
Reboot the host if enrollment fails.

BUG=720774
==========

to

==========
Make controller can reboot the host if the enrollment of the host failed.


BUG=720774
==========

[minch1, 2017-05-23 00:24:14]

Description was changed from

==========
Make controller can reboot the host if the enrollment of the host failed.


BUG=720774
==========

to

==========
Let controller can reboot the host if the enrollment of the host failed.

Changes in this cl,
1.Add MESSAGE_REBOOT in ProtoDecoder. If host (slave device) enrollment 
status received by the controller (master device) is 
ENROLLMENT_STATUS_FAILURE. The controller can send MESSAGE_REBOOT to 
the host. To notify host reboot itself. Then, it can be discovered by 
the controller again after reboot.


BUG=720774
==========

[minch1, 2017-05-23 00:27:32]

Description was changed from

==========
Let controller can reboot the host if the enrollment of the host failed.

Changes in this cl,
1.Add MESSAGE_REBOOT in ProtoDecoder. If host (slave device) enrollment 
status received by the controller (master device) is 
ENROLLMENT_STATUS_FAILURE. The controller can send MESSAGE_REBOOT to 
the host. To notify host reboot itself. Then, it can be discovered by 
the controller again after reboot.


BUG=720774
==========

to

==========
Bootstrapping: CrOS device should automatically reboot itself after enrollment
failed.

Changes in this cl,
1.Add MESSAGE_REBOOT in ProtoDecoder. If host (slave device) enrollment 
status received by the controller (master device) is 
ENROLLMENT_STATUS_FAILURE. The controller can send MESSAGE_REBOOT to 
the host. To notify host reboot itself. Then, it can be discovered by 
the controller again after reboot. This make sure the host device can
be enrolled successfully without user interaction.


BUG=720774
==========

[minch1, 2017-05-23 00:47:11]

The CQ bit was checked by minch@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 00:48:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 01:22:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 01:22:11]

Dry run: This issue passed the CQ dry run.

[minch1, 2017-05-23 16:16:25]

minch@chromium.org changed reviewers:
+ xiyuan@chromium.org, zork@chromium.org

[minch1, 2017-05-23 16:16:26]

zork@, xiyuan@, xdai@, could you please help review? Thanks.

[xdai1, 2017-05-23 20:28:01]

lgtm

[xiyuan, 2017-05-24 17:12:04]

lgtm

Can you update CL description?

- Remove "Changes in this cl,"
- Remove "1." since it is the only bullet

Something like:

Bootstrapping: Reboot on enrollment failure

Add MESSAGE_REBOOT to ProtoDecoder. If host (slave device) enrollment 
status received by the controller (master device) is 
ENROLLMENT_STATUS_FAILURE. The controller can send MESSAGE_REBOOT to 
the host to notify the host to reboot. The host would be re-discovered
by the controller after the reboot to restart the enrollment process.
So that the host device can be enrolled successfully without user
interaction.

BUG=720774

[minch1, 2017-05-24 17:34:57]

Description was changed from

==========
Bootstrapping: CrOS device should automatically reboot itself after enrollment
failed.

Changes in this cl,
1.Add MESSAGE_REBOOT in ProtoDecoder. If host (slave device) enrollment 
status received by the controller (master device) is 
ENROLLMENT_STATUS_FAILURE. The controller can send MESSAGE_REBOOT to 
the host. To notify host reboot itself. Then, it can be discovered by 
the controller again after reboot. This make sure the host device can
be enrolled successfully without user interaction.


BUG=720774
==========

to

==========
Bootstrapping: Reboot on enrollment failure

Add MESSAGE_REBOOT to ProtoDecoder. If host (slave device) enrollment 
status received by the controller (master device) is 
ENROLLMENT_STATUS_FAILURE. The controller can send MESSAGE_REBOOT to 
the host to notify the host to reboot. The host would be re-discovered
by the controller after the reboot to restart the enrollment process.
So that the host device can be enrolled successfully without user
interaction.

BUG=720774
==========

[Zachary Kuznia, 2017-05-24 23:44:11]

lgtm

[minch1, 2017-05-24 23:47:32]

The CQ bit was checked by minch@chromium.org

[commit-bot: I haz the power, 2017-05-24 23:48:07]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 00:20:00]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495669652291360,
"parent_rev": "b964d748bd770259233bb89425ba869829d3e4e0", "commit_rev":
"617dcc23c266b0b3c50fdb58052fdc6818e6b06b"}

[commit-bot: I haz the power, 2017-05-25 00:20:12]

Description was changed from

==========
Bootstrapping: Reboot on enrollment failure

Add MESSAGE_REBOOT to ProtoDecoder. If host (slave device) enrollment 
status received by the controller (master device) is 
ENROLLMENT_STATUS_FAILURE. The controller can send MESSAGE_REBOOT to 
the host to notify the host to reboot. The host would be re-discovered
by the controller after the reboot to restart the enrollment process.
So that the host device can be enrolled successfully without user
interaction.

BUG=720774
==========

to

==========
Bootstrapping: Reboot on enrollment failure

Add MESSAGE_REBOOT to ProtoDecoder. If host (slave device) enrollment 
status received by the controller (master device) is 
ENROLLMENT_STATUS_FAILURE. The controller can send MESSAGE_REBOOT to 
the host to notify the host to reboot. The host would be re-discovered
by the controller after the reboot to restart the enrollment process.
So that the host device can be enrolled successfully without user
interaction.

BUG=720774

Review-Url: https://codereview.chromium.org/2901653002
Cr-Commit-Position: refs/heads/master@{#474486}
Committed:
https://chromium.googlesource.com/chromium/src/+/617dcc23c266b0b3c50fdb58052f...
==========

[commit-bot: I haz the power, 2017-05-25 00:20:13]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/617dcc23c266b0b3c50fdb58052f...

[minch1, 2017-05-25 04:34:36]

Description was changed from

==========
Bootstrapping: Reboot on enrollment failure

Add MESSAGE_REBOOT to ProtoDecoder. If host (slave device) enrollment 
status received by the controller (master device) is 
ENROLLMENT_STATUS_FAILURE. The controller can send MESSAGE_REBOOT to 
the host to notify the host to reboot. The host would be re-discovered
by the controller after the reboot to restart the enrollment process.
So that the host device can be enrolled successfully without user
interaction.

BUG=720774

Review-Url: https://codereview.chromium.org/2901653002
Cr-Commit-Position: refs/heads/master@{#474486}
Committed:
https://chromium.googlesource.com/chromium/src/+/617dcc23c266b0b3c50fdb58052f...
==========

to

==========
Bootstrapping: Reboot on enrollment failure

Add MESSAGE_REBOOT to ProtoDecoder. If host (slave device) enrollment 
status received by the controller (master device) is 
ENROLLMENT_STATUS_FAILURE. The controller can send MESSAGE_REBOOT to 
the host to notify the host to reboot. The host would be re-discovered
by the controller after the reboot to restart the enrollment process.
So that the host device can be enrolled successfully without user
interaction.

BUG=720719

Review-Url: https://codereview.chromium.org/2901653002
Cr-Commit-Position: refs/heads/master@{#474486}
Committed:
https://chromium.googlesource.com/chromium/src/+/617dcc23c266b0b3c50fdb58052f...
==========