Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Issue 2901613002: Remove navigation_service_unittests, along with the service itself. (Closed)

Created:
3 years, 7 months ago by Elliot Glaysher
Modified:
3 years, 7 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, Peter Beverloo, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, kalyank, darin (slow to review), jochen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove navigation_service_unittests, along with the service itself. Also removes everything that depends on it, including its inclusion in chrome, where it was never used, along with two subdirectories in mash/, which appeared to be defunct. BUG=722546 Review-Url: https://codereview.chromium.org/2901613002 Cr-Commit-Position: refs/heads/master@{#473735} Committed: https://chromium.googlesource.com/chromium/src/+/965f939c0b2db8ecb2b7afd607f2b161d8872c06

Patch Set 1 #

Patch Set 2 : Fix isolate files? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3067 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/browser/DEPS View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/browser/shell_content_browser_client.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M mash/BUILD.gn View 1 chunk +0 lines, -10 lines 0 comments Download
D mash/browser/BUILD.gn View 1 chunk +0 lines, -65 lines 0 comments Download
D mash/browser/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D mash/browser/browser.h View 1 chunk +0 lines, -67 lines 0 comments Download
D mash/browser/browser.cc View 1 chunk +0 lines, -918 lines 0 comments Download
D mash/browser/debug_view.h View 1 chunk +0 lines, -51 lines 0 comments Download
D mash/browser/debug_view.cc View 1 chunk +0 lines, -68 lines 0 comments Download
D mash/browser/main.cc View 1 chunk +0 lines, -12 lines 0 comments Download
D mash/browser/manifest.json View 1 chunk +0 lines, -12 lines 0 comments Download
D mash/browser/public/interfaces/BUILD.gn View 1 chunk +0 lines, -17 lines 0 comments Download
D mash/browser/public/interfaces/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D mash/browser/public/interfaces/constants.mojom View 1 chunk +0 lines, -7 lines 0 comments Download
D mash/webtest/BUILD.gn View 1 chunk +0 lines, -57 lines 0 comments Download
D mash/webtest/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D mash/webtest/main.cc View 1 chunk +0 lines, -12 lines 0 comments Download
D mash/webtest/manifest.json View 1 chunk +0 lines, -12 lines 0 comments Download
D mash/webtest/public/interfaces/BUILD.gn View 1 chunk +0 lines, -17 lines 0 comments Download
D mash/webtest/public/interfaces/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D mash/webtest/public/interfaces/constants.mojom View 1 chunk +0 lines, -7 lines 0 comments Download
D mash/webtest/webtest.h View 1 chunk +0 lines, -58 lines 0 comments Download
D mash/webtest/webtest.cc View 1 chunk +0 lines, -213 lines 0 comments Download
D services/navigation/BUILD.gn View 1 chunk +0 lines, -87 lines 0 comments Download
D services/navigation/DEPS View 1 chunk +0 lines, -9 lines 0 comments Download
D services/navigation/OWNERS View 1 chunk +0 lines, -5 lines 0 comments Download
D services/navigation/README.md View 1 chunk +0 lines, -67 lines 0 comments Download
D services/navigation/embedder_manifest.json View 1 chunk +0 lines, -5 lines 0 comments Download
D services/navigation/manifest.json View 1 chunk +0 lines, -19 lines 0 comments Download
D services/navigation/navigation.h View 1 chunk +0 lines, -57 lines 0 comments Download
D services/navigation/navigation.cc View 1 chunk +0 lines, -87 lines 0 comments Download
D services/navigation/navigation_unittest.cc View 1 chunk +0 lines, -87 lines 0 comments Download
D services/navigation/public/cpp/BUILD.gn View 1 chunk +0 lines, -19 lines 0 comments Download
D services/navigation/public/cpp/view.h View 1 chunk +0 lines, -114 lines 0 comments Download
D services/navigation/public/cpp/view.cc View 1 chunk +0 lines, -193 lines 0 comments Download
D services/navigation/public/cpp/view_delegate.h View 1 chunk +0 lines, -47 lines 0 comments Download
D services/navigation/public/cpp/view_observer.h View 1 chunk +0 lines, -33 lines 0 comments Download
D services/navigation/public/interfaces/BUILD.gn View 1 chunk +0 lines, -17 lines 0 comments Download
D services/navigation/public/interfaces/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D services/navigation/public/interfaces/view.mojom View 1 chunk +0 lines, -123 lines 0 comments Download
D services/navigation/unittest_manifest.json View 1 chunk +0 lines, -11 lines 0 comments Download
D services/navigation/view_impl.h View 1 chunk +0 lines, -114 lines 0 comments Download
D services/navigation/view_impl.cc View 1 chunk +0 lines, -320 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 1 2 chunks +0 lines, -12 lines 0 comments Download
M testing/buildbot/chromium.win.json View 1 1 chunk +0 lines, -6 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 1 chunk +0 lines, -4 lines 0 comments Download
M tools/determinism/deterministic_build_whitelist.pyl View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (12 generated)
Elliot Glaysher
This deletes //services/navigation along with //mash/{browser,webtest}. Have I caught everything? Can more of //mash/ be ...
3 years, 7 months ago (2017-05-22 22:41:58 UTC) #8
Ben Goodger (Google)
lgtm
3 years, 7 months ago (2017-05-22 22:52:16 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2901613002/20001
3 years, 7 months ago (2017-05-22 23:05:41 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 23:12:39 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/965f939c0b2db8ecb2b7afd607f2...

Powered by Google App Engine
This is Rietveld 408576698