Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2901603002: Disable logging redirect on chromeos. (Closed)

Created:
3 years, 7 months ago by achuithb
Modified:
3 years, 6 months ago
Reviewers:
xiyuan, jdufault, nednguyen
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Disable logging redirect on chromeos. All logging is now available in /var/log/chrome/chrome. BUG=chromium:724273 TEST=manual Review-Url: https://codereview.chromium.org/2901603002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/509327f965c3a6885c1e5bc8abf5ced0478d72d7

Patch Set 1 #

Total comments: 2

Patch Set 2 : Ned feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (15 generated)
achuithb
PTAL, Xiyuan
3 years, 7 months ago (2017-05-22 21:26:52 UTC) #4
xiyuan
lgtm
3 years, 7 months ago (2017-05-22 22:38:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2901603002/1
3 years, 7 months ago (2017-05-22 23:43:56 UTC) #9
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 7 months ago (2017-05-22 23:43:58 UTC) #11
achuithb
Jake, could you PTAL
3 years, 7 months ago (2017-05-23 07:34:52 UTC) #13
jdufault
lgtm
3 years, 7 months ago (2017-05-23 17:13:27 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2901603002/1
3 years, 7 months ago (2017-05-23 20:54:34 UTC) #16
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 7 months ago (2017-05-23 20:54:35 UTC) #18
achuithb
Ned, could you PTAL
3 years, 7 months ago (2017-05-23 20:57:11 UTC) #20
nednguyen
lgtm https://codereview.chromium.org/2901603002/diff/1/telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py File telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py (right): https://codereview.chromium.org/2901603002/diff/1/telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py#newcode80 telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py:80: # Disable chrome logging redirect, nits: end this ...
3 years, 7 months ago (2017-05-23 21:08:11 UTC) #21
achuithb
https://codereview.chromium.org/2901603002/diff/1/telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py File telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py (right): https://codereview.chromium.org/2901603002/diff/1/telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py#newcode80 telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py:80: # Disable chrome logging redirect, On 2017/05/23 21:08:11, nednguyen ...
3 years, 6 months ago (2017-06-01 21:37:53 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2901603002/20001
3 years, 6 months ago (2017-06-01 21:38:04 UTC) #25
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 22:05:54 UTC) #28
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698