|
|
Chromium Code Reviews
DescriptionDisable logging redirect on chromeos.
All logging is now available in /var/log/chrome/chrome.
BUG=chromium:724273
TEST=manual
Review-Url: https://codereview.chromium.org/2901603002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/509327f965c3a6885c1e5bc8abf5ced0478d72d7
Patch Set 1 #
Total comments: 2
Patch Set 2 : Ned feedback #Messages
Total messages: 28 (15 generated)
The CQ bit was checked by achuith@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
achuith@chromium.org changed reviewers: + xiyuan@chromium.org
PTAL, Xiyuan
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by achuith@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-catapult-committers". Note that this has nothing to do with OWNERS files.
achuith@chromium.org changed reviewers: + jdufault@chromium.org
Jake, could you PTAL
lgtm
The CQ bit was checked by achuith@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-catapult-committers". Note that this has nothing to do with OWNERS files.
achuith@chromium.org changed reviewers: + nednguyen@google.com
Ned, could you PTAL
lgtm https://codereview.chromium.org/2901603002/diff/1/telemetry/telemetry/interna... File telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py (right): https://codereview.chromium.org/2901603002/diff/1/telemetry/telemetry/interna... telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py:80: # Disable chrome logging redirect, nits: end this sentence with "." & add bug reference for more context.
https://codereview.chromium.org/2901603002/diff/1/telemetry/telemetry/interna... File telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py (right): https://codereview.chromium.org/2901603002/diff/1/telemetry/telemetry/interna... telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py:80: # Disable chrome logging redirect, On 2017/05/23 21:08:11, nednguyen wrote: > nits: end this sentence with "." & add bug reference for more context. Done.
The CQ bit was checked by achuith@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org, jdufault@chromium.org, nednguyen@google.com Link to the patchset: https://codereview.chromium.org/2901603002/#ps20001 (title: "Ned feedback")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496353077923980,
"parent_rev": "e59e87ea3fbbddbb5ba6174c776fbe61c70e2d00", "commit_rev":
"509327f965c3a6885c1e5bc8abf5ced0478d72d7"}
Message was sent while issue was closed.
Description was changed from ========== Disable logging redirect on chromeos. All logging is now available in /var/log/chrome/chrome. BUG=chromium:724273 TEST=manual ========== to ========== Disable logging redirect on chromeos. All logging is now available in /var/log/chrome/chrome. BUG=chromium:724273 TEST=manual Review-Url: https://codereview.chromium.org/2901603002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapu... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/github.com/catapult-project/catapu... |
