Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4231)

Unified Diff: chrome/common/pdf_uma.h

Issue 2901563003: PDF: Add UMA to track embedded PDF triggered drive-by downloads. (Closed)
Patch Set: remove stray comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/pdf_uma.h
diff --git a/chrome/common/pdf_uma.h b/chrome/common/pdf_uma.h
new file mode 100644
index 0000000000000000000000000000000000000000..43ad026c201ceba238c04e04cce53a67f58c24e2
--- /dev/null
+++ b/chrome/common/pdf_uma.h
@@ -0,0 +1,22 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
Lei Zhang 2017/05/24 22:39:21 It's half way through 2017.
tommycli 2017/05/25 18:16:37 Done.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_COMMON_PDF_UMA_H_
+#define CHROME_COMMON_PDF_UMA_H_
+
+#include "base/macros.h"
Lei Zhang 2017/05/24 22:39:21 Are there any macros here?
tommycli 2017/05/25 18:16:37 Done.
+
+// Must be kept in sync with PDFLoadStatus enum in histograms.xml.
+// This enum should be treated as append-only.
+enum class PDFLoadStatus {
+ LOADED_FULL_PAGE_PDF_WITH_PDFIUM = 0,
Lei Zhang 2017/05/24 22:39:21 FYI, there was a thread from last month title: [c
tommycli 2017/05/25 18:16:38 Done.
+ LOADED_EMBEDDED_PDF_WITH_PDFIUM = 1,
+ SHOWED_DISABLED_PLUGIN_PLACEHOLDER_FOR_EMBEDDED_PDF = 2,
+ TRIGGERED_NO_GESTURE_DRIVE_BY_DOWNLOAD = 3,
+ PDF_LOAD_STATUS_COUNT
+};
+
+void ReportPDFLoadStatus(PDFLoadStatus status);
+
+#endif // CHROME_COMMON_PDF_UMA_H_
« chrome/common/BUILD.gn ('K') | « chrome/common/BUILD.gn ('k') | chrome/common/pdf_uma.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698