PDF: Add UMA to track embedded PDF triggered drive-by downloads.

chrome/common/pdf_uma.h

+// Copyright 2016 The Chromium Authors. All rights reserved.

[Lei Zhang, 2017/05/24 22:39:21]

It's half way through 2017.

[tommycli, 2017/05/25 18:16:37]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_COMMON_PDF_UMA_H_
+#define CHROME_COMMON_PDF_UMA_H_
+
+#include "base/macros.h"

[Lei Zhang, 2017/05/24 22:39:21]

Are there any macros here?

[tommycli, 2017/05/25 18:16:37]

Done.

+
+// Must be kept in sync with PDFLoadStatus enum in histograms.xml.
+// This enum should be treated as append-only.
+enum class PDFLoadStatus {
+  LOADED_FULL_PAGE_PDF_WITH_PDFIUM = 0,

[Lei Zhang, 2017/05/24 22:39:21]

FYI, there was a thread from last month title:

[chromium-dev] PSA: Chromium style no longer prefers FOO over kFoo for enums

[tommycli, 2017/05/25 18:16:38]

Done.

+  LOADED_EMBEDDED_PDF_WITH_PDFIUM = 1,
+  SHOWED_DISABLED_PLUGIN_PLACEHOLDER_FOR_EMBEDDED_PDF = 2,
+  TRIGGERED_NO_GESTURE_DRIVE_BY_DOWNLOAD = 3,
+  PDF_LOAD_STATUS_COUNT
+};
+
+void ReportPDFLoadStatus(PDFLoadStatus status);
+
+#endif  // CHROME_COMMON_PDF_UMA_H_