chromeos: adds TouchDeviceServer and wires up in mushrome

chromeos: adds TouchDeviceServer and wires up in mushrome

TouchDeviceServer is necessary for hooking up AshTouchTransformController in mus/mash.

BUG=705686
TEST=covered by tests
R=erg@chromium.org,rockot@chromium.org,tsepez@chromium.org

Review-Url: https://codereview.chromium.org/2901563002
Cr-Original-Commit-Position: refs/heads/master@{#473651}
Committed: https://chromium.googlesource.com/chromium/src/+/68e20f488cc2ea0216832c8fe3640d9b748595d2
Review-Url: https://codereview.chromium.org/2901563002
Cr-Commit-Position: refs/heads/master@{#473734}
Committed: https://chromium.googlesource.com/chromium/src/+/7265b1cc285ca137198ba1f2d75bfc649aa2c3a3

[sky, 2017-05-22 16:25:56]

tsepez: mojom/struct_traits
rockot: mojo/public/tools/bindings/*
erg: the rest

[sky, 2017-05-22 16:25:58]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 16:26:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 17:27:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 17:27:41]

Dry run: This issue passed the CQ dry run.

[Elliot Glaysher, 2017-05-22 17:54:45]

lgtm, comment is not really related to this patch.

https://codereview.chromium.org/2901563002/diff/1/services/ui/public/interfac...
File services/ui/public/interfaces/input_devices/touch_device_server.mojom
(right):

https://codereview.chromium.org/2901563002/diff/1/services/ui/public/interfac...
services/ui/public/interfaces/input_devices/touch_device_server.mojom:11:
ConfigureTouchDevices(map<int32, double> scales,
slightly off topic: is it the correct thing for mojo maps to resolve to
std::unordered_map<>? I remember it coming up on the ml that unordered_maps were
larger for small number of items.

[sky, 2017-05-22 18:04:04]

Not sure what you mean by the comment isn't really related to the patch. The
change in Shell enables AshTouchTransformController, which is a
TouchTransformController.

https://codereview.chromium.org/2901563002/diff/1/services/ui/public/interfac...
File services/ui/public/interfaces/input_devices/touch_device_server.mojom
(right):

https://codereview.chromium.org/2901563002/diff/1/services/ui/public/interfac...
services/ui/public/interfaces/input_devices/touch_device_server.mojom:11:
ConfigureTouchDevices(map<int32, double> scales,
On 2017/05/22 17:54:44, Elliot Glaysher wrote:
> slightly off topic: is it the correct thing for mojo maps to resolve to
> std::unordered_map<>? I remember it coming up on the ml that unordered_maps
were
> larger for small number of items.

715340 is against whether mojo bindings should still use unordered_map.

[sky, 2017-05-22 18:04:19]

Description was changed from

==========
chromeos: adds TouchDeviceServer and wires up in mushrome

TouchDeviceServer is necessary for hooking up TouchDeviceController in
mus/mash.

BUG=705686
TEST=covered by tests
R=erg@chromium.org,rockot@chromium.org,tsepez@chromium.org
==========

to

==========
chromeos: adds TouchDeviceServer and wires up in mushrome

TouchDeviceServer is necessary for hooking up AshTouchTransformController in
mus/mash.

BUG=705686
TEST=covered by tests
R=erg@chromium.org,rockot@chromium.org,tsepez@chromium.org
==========

[sky, 2017-05-22 18:04:36]

I see what you mean now, I meant AshTouchTransformController. I updated comment.

[Ken Rockot(use gerrit already), 2017-05-22 18:04:53]

lgtm

[Elliot Glaysher, 2017-05-22 18:17:51]

On 2017/05/22 18:04:36, sky wrote:
> I see what you mean now, I meant AshTouchTransformController. I updated
comment.

what i meant was my off topic comment about unordered_map<> was not related to
this patch.

[Tom Sepez, 2017-05-22 19:02:28]

lgtm

[sky, 2017-05-22 19:09:36]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2017-05-22 19:10:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 19:17:36]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495480176360240, "parent_rev":
"e51cd18b640fe393dafefffdd24ecf40b2d54cd7", "commit_rev":
"68e20f488cc2ea0216832c8fe3640d9b748595d2"}

[commit-bot: I haz the power, 2017-05-22 19:17:47]

Description was changed from

==========
chromeos: adds TouchDeviceServer and wires up in mushrome

TouchDeviceServer is necessary for hooking up AshTouchTransformController in
mus/mash.

BUG=705686
TEST=covered by tests
R=erg@chromium.org,rockot@chromium.org,tsepez@chromium.org
==========

to

==========
chromeos: adds TouchDeviceServer and wires up in mushrome

TouchDeviceServer is necessary for hooking up AshTouchTransformController in
mus/mash.

BUG=705686
TEST=covered by tests
R=erg@chromium.org,rockot@chromium.org,tsepez@chromium.org

Review-Url: https://codereview.chromium.org/2901563002
Cr-Commit-Position: refs/heads/master@{#473651}
Committed:
https://chromium.googlesource.com/chromium/src/+/68e20f488cc2ea0216832c8fe364...
==========

[commit-bot: I haz the power, 2017-05-22 19:17:48]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/68e20f488cc2ea0216832c8fe364...

[Marijn Kruisselbrink, 2017-05-22 19:49:23]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2897863004/ by mek@chromium.org.

The reason for reverting is: Failed compile on
https://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20x86-ge...:

/b/c/goma_client/gomacc i686-pc-linux-gnu-g++
-B/b/c/b/ChromiumOS_x86_generic_Compile/.cros_cache/chrome-sdk/tarballs/x86-generic+9536.0.0+target_toolchain/usr/x86_64-pc-linux-gnu/i686-pc-linux-gnu/binutils-bin/2.25.51-gold
-MMD -MF obj/ash/ash/shell_port_classic.o.d -DASH_IMPLEMENTATION
-DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUSE_ASH=1 -DUSE_AURA=1 -DUSE_NSS_CERTS=1
-DUSE_OZONE=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL
-DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -D_FILE_OFFSET_BITS=64
-D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS
-D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -DOS_CHROMEOS -DNDEBUG -DNVALGRIND
-DDYNAMIC_ANNOTATIONS_ENABLED=0 -DUSE_EGL -DTOOLKIT_VIEWS=1
-DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION
-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DUCHAR_TYPE=uint16_t
-DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_HAS_PNG_LIBRARY
-DSK_HAS_WEBP_LIBRARY -DSK_HAS_JPEG_LIBRARY -DSK_SUPPORT_GPU=1
-DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD
-DMESA_EGL_NO_X11_HEADERS -I../.. -Igen -I../../third_party/libwebp
-I../../third_party/khronos -I../../gpu -I../../third_party/ced/src
-I../../third_party/icu/source/common -I../../third_party/icu/source/i18n
-I../../skia/config -I../../skia/ext -I../../third_party/skia/include/c
-I../../third_party/skia/include/config -I../../third_party/skia/include/core
-I../../third_party/skia/include/effects -I../../third_party/skia/include/encode
-I../../third_party/skia/include/images -I../../third_party/skia/include/lazy
-I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf
-I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports
-I../../third_party/skia/include/utils
-I../../third_party/skia/third_party/vulkan -I../../third_party/skia/include/gpu
-I../../third_party/skia/src/gpu -I../../third_party/skia/src/sksl
-I/b/c/b/ChromiumOS_x86_generic_Compile/.cros_cache/chrome-sdk/tarballs/x86-generic+9536.0.0+sysroot_chromeos-base_chromeos-chrome.tar.xz/usr/include/dbus-1.0
-I/b/c/b/ChromiumOS_x86_generic_Compile/.cros_cache/chrome-sdk/tarballs/x86-generic+9536.0.0+sysroot_chromeos-base_chromeos-chrome.tar.xz/usr/lib/dbus-1.0/include
-I../../third_party/protobuf/src -Igen/protoc_out
-I../../third_party/protobuf/src -I../../third_party/libwebm/source
-I../../third_party/boringssl/src/include
-I/b/c/b/ChromiumOS_x86_generic_Compile/.cros_cache/chrome-sdk/tarballs/x86-generic+9536.0.0+sysroot_chromeos-base_chromeos-chrome.tar.xz/usr/include/nss
-I/b/c/b/ChromiumOS_x86_generic_Compile/.cros_cache/chrome-sdk/tarballs/x86-generic+9536.0.0+sysroot_chromeos-base_chromeos-chrome.tar.xz/usr/include/nspr
-I../../third_party/WebKit -Igen/third_party/WebKit -I../../v8/include
-Igen/v8/include -I../../third_party/qcms/src -Igen
-I../../third_party/mesa/src/include -fno-strict-aliasing
-Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__=
-funwind-tables -fPIC -pipe -B../../third_party/binutils/Linux_x64/Release/bin
-m32 -msse2 -mfpmath=sse -mmmx -pthread -Wall -Werror -Wno-unused-local-typedefs
-Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-unused-parameter
-O2 -fno-ident -fdata-sections -ffunction-sections -fno-omit-frame-pointer -g2
-gsplit-dwarf
--sysroot=../../../.cros_cache/chrome-sdk/tarballs/x86-generic+9536.0.0+sysroot_chromeos-base_chromeos-chrome.tar.xz
-fvisibility=hidden -std=gnu++11 -Wno-narrowing -fno-rtti -fno-exceptions
-fvisibility-inlines-hidden -march=i686 -pipe -march=i686 -pipe -pipe
-march=i686 -mfpmath=sse -mmmx -msse -msse2 -msse3 -D__google_stl_debug_vector=1
-c ../../ash/aura/shell_port_classic.cc -o obj/ash/ash/shell_port_classic.o
../../ash/aura/shell_port_classic.cc: In member function 'virtual
std::unique_ptr<display::TouchTransformSetter>
ash::ShellPortClassic::CreateTouchTransformDelegate()':
../../ash/aura/shell_port_classic.cc:126:10: error: cannot bind
'std::unique_ptr<display::DefaultTouchTransformSetter>' lvalue to
'std::unique_ptr<display::DefaultTouchTransformSetter>&&'
   return delegate;
          ^
In file included from
/b/c/b/ChromiumOS_x86_generic_Compile/.cros_cache/chrome-sdk/tarballs/x86-generic+9536.0.0+target_toolchain/usr/x86_64-pc-linux-gnu/i686-pc-linux-gnu/gcc-bin/4.9.x/../../../../lib/gcc/i686-pc-linux-gnu/4.9.x/include/g++-v4/memory:81:0,
                 from ../../ash/aura/shell_port_classic.h:8,
                 from ../../ash/aura/shell_port_classic.cc:5:
/b/c/b/ChromiumOS_x86_generic_Compile/.cros_cache/chrome-sdk/tarballs/x86-generic+9536.0.0+target_toolchain/usr/x86_64-pc-linux-gnu/i686-pc-linux-gnu/gcc-bin/4.9.x/../../../../lib/gcc/i686-pc-linux-gnu/4.9.x/include/g++-v4/bits/unique_ptr.h:220:2:
note: initializing argument 1 of 'std::unique_ptr<_Tp,
_Dp>::unique_ptr(std::unique_ptr<_Up, _Ep>&&) [with _Up =
display::DefaultTouchTransformSetter; _Ep =
std::default_delete<display::DefaultTouchTransformSetter>;
<template-parameter-2-3> = void; _Tp = display::TouchTransformSetter; _Dp =
std::default_delete<display::TouchTransformSetter>]'
  unique_ptr(unique_ptr<_Up, _Ep>&& __u) noexcept
  ^
../../ash/aura/shell_port_classic.cc:127:1: error: control reaches end of
non-void function [-Werror=return-type]
 }
 ^.

[findit-for-me, 2017-05-22 19:52:27]

Findit (https://goo.gl/kROfz5) confirmed this CL at revision 473651 as the
culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

[sky, 2017-05-22 20:49:16]

Description was changed from

==========
chromeos: adds TouchDeviceServer and wires up in mushrome

TouchDeviceServer is necessary for hooking up AshTouchTransformController in
mus/mash.

BUG=705686
TEST=covered by tests
R=erg@chromium.org,rockot@chromium.org,tsepez@chromium.org

Review-Url: https://codereview.chromium.org/2901563002
Cr-Commit-Position: refs/heads/master@{#473651}
Committed:
https://chromium.googlesource.com/chromium/src/+/68e20f488cc2ea0216832c8fe364...
==========

to

==========
chromeos: adds TouchDeviceServer and wires up in mushrome

TouchDeviceServer is necessary for hooking up AshTouchTransformController in
mus/mash.

BUG=705686
TEST=covered by tests
R=erg@chromium.org,rockot@chromium.org,tsepez@chromium.org

Review-Url: https://codereview.chromium.org/2901563002
Cr-Commit-Position: refs/heads/master@{#473651}
Committed:
https://chromium.googlesource.com/chromium/src/+/68e20f488cc2ea0216832c8fe364...
==========

[sky, 2017-05-22 20:51:49]

This was reverted because of differences in compiler on a chromeos bot. See
diffs between patchset 2 and latest for fix. Elliot, could you take another
look?

[sky, 2017-05-22 20:51:53]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 20:52:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Elliot Glaysher, 2017-05-22 20:53:10]

still lgtm

[sky, 2017-05-22 20:58:23]

The CQ bit was unchecked by sky@chromium.org

[sky, 2017-05-22 20:58:27]

The CQ bit was checked by sky@chromium.org

[sky, 2017-05-22 20:58:28]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2901563002/#ps60001
(title: "no temporary")

[commit-bot: I haz the power, 2017-05-22 20:58:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 23:11:06]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495486707839440,
"parent_rev": "579f0a9f7b3a6428db7ae8aa457fd197ac325fe9", "commit_rev":
"7265b1cc285ca137198ba1f2d75bfc649aa2c3a3"}

[commit-bot: I haz the power, 2017-05-22 23:11:23]

Description was changed from

==========
chromeos: adds TouchDeviceServer and wires up in mushrome

TouchDeviceServer is necessary for hooking up AshTouchTransformController in
mus/mash.

BUG=705686
TEST=covered by tests
R=erg@chromium.org,rockot@chromium.org,tsepez@chromium.org

Review-Url: https://codereview.chromium.org/2901563002
Cr-Commit-Position: refs/heads/master@{#473651}
Committed:
https://chromium.googlesource.com/chromium/src/+/68e20f488cc2ea0216832c8fe364...
==========

to

==========
chromeos: adds TouchDeviceServer and wires up in mushrome

TouchDeviceServer is necessary for hooking up AshTouchTransformController in
mus/mash.

BUG=705686
TEST=covered by tests
R=erg@chromium.org,rockot@chromium.org,tsepez@chromium.org

Review-Url: https://codereview.chromium.org/2901563002
Cr-Original-Commit-Position: refs/heads/master@{#473651}
Committed:
https://chromium.googlesource.com/chromium/src/+/68e20f488cc2ea0216832c8fe364...
Review-Url: https://codereview.chromium.org/2901563002
Cr-Commit-Position: refs/heads/master@{#473734}
Committed:
https://chromium.googlesource.com/chromium/src/+/7265b1cc285ca137198ba1f2d75b...
==========

[commit-bot: I haz the power, 2017-05-22 23:11:24]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/7265b1cc285ca137198ba1f2d75b...