Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2901553002: [heap] Do not use page markbits in UnreachableObjectsFilter. (Closed)

Created:
3 years, 7 months ago by ulan
Modified:
3 years, 7 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office)
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Do not use page markbits in UnreachableObjectsFilter. Currently the UnreachableObjectsFilter does not work if incremental marking is in progress since they both use the same markbits. This patch changes the UnreachableObjectsFilter to use local markbits. BUG= Review-Url: https://codereview.chromium.org/2901553002 Cr-Commit-Position: refs/heads/master@{#45467} Committed: https://chromium.googlesource.com/v8/v8/+/9b1d22fc2cf4fb95383937a8bca2f825ec942e46

Patch Set 1 #

Patch Set 2 : includes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -10 lines) Patch
M src/heap/heap.cc View 1 3 chunks +28 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
ulan
ptal
3 years, 7 months ago (2017-05-22 15:40:38 UTC) #2
Hannes Payer (out of office)
lgtm
3 years, 7 months ago (2017-05-22 15:57:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2901553002/20001
3 years, 7 months ago (2017-05-22 15:57:45 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 16:30:50 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/9b1d22fc2cf4fb95383937a8bca2f825ec9...

Powered by Google App Engine
This is Rietveld 408576698