Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Issue 2901533003: Revert of Track task ids for navigations cross multiple tabs. (Closed)

Created:
3 years, 7 months ago by Nicolas Zea
Modified:
3 years, 7 months ago
Reviewers:
shenchao
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Track task ids for navigations cross multiple tabs. (patchset #4 id:80001 of https://codereview.chromium.org/2868043003/ ) Reason for revert: crbug.com/725026 and crbug.com/724497 Original issue's description: > Track task ids for navigations cross multiple tabs. > > This is a following step to generate task ids for navigations. Now we > can track navigation relationship cross multiple tabs. If navigation B > in tab2 is clicked from navigation A in tab1, then navigation A is B's > parent task. And this is generalized to more than 2 tabs. > > BUG=707978 > R=zea@chromium.org > > Review-Url: https://codereview.chromium.org/2868043003 > Cr-Commit-Position: refs/heads/master@{#472667} > Committed: https://chromium.googlesource.com/chromium/src/+/854b8bcfc787413293c86eddd979a3fd1936fb1a TBR=shenchao@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=707978 Review-Url: https://codereview.chromium.org/2901533003 Cr-Commit-Position: refs/heads/master@{#473790} Committed: https://chromium.googlesource.com/chromium/src/+/7e3869bafd618a75247cd2082e6e72343425ec7e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -245 lines) Patch
M components/sync_sessions/sessions_sync_manager.cc View 1 chunk +1 line, -5 lines 0 comments Download
M components/sync_sessions/sessions_sync_manager_unittest.cc View 6 chunks +5 lines, -91 lines 0 comments Download
M components/sync_sessions/task_tracker.h View 4 chunks +1 line, -16 lines 0 comments Download
M components/sync_sessions/task_tracker.cc View 7 chunks +26 lines, -63 lines 0 comments Download
M components/sync_sessions/task_tracker_unittest.cc View 2 chunks +0 lines, -70 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Nicolas Zea
Created Revert of Track task ids for navigations cross multiple tabs.
3 years, 7 months ago (2017-05-23 01:25:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2901533003/1
3 years, 7 months ago (2017-05-23 01:25:38 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 02:52:11 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7e3869bafd618a75247cd2082e6e...

Powered by Google App Engine
This is Rietveld 408576698