Rename GetPreferredSize to CalculatePreferredSize in ash/

Rename GetPreferredSize to CalculatePreferredSize in ash/

Also remove the function completely where it makes the code simpler:
- FrameCaptionButton
- ExitWarningWidgetDelegateView
- UserCardView

BUG=none

Review-Url: https://codereview.chromium.org/2901503003
Cr-Commit-Position: refs/heads/master@{#473715}
Committed: https://chromium.googlesource.com/chromium/src/+/f285a784f8a21236d5c17dc4576306844654ffee

[Evan Stade, 2017-05-22 17:18:51]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[Evan Stade, 2017-05-22 17:18:56]

estade@chromium.org changed reviewers:
+ sky@chromium.org

[commit-bot: I haz the power, 2017-05-22 17:19:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2017-05-22 17:30:58]

Is there a reason not to explicitly set the preferred size for the overrides
that just hardcode a return value?

https://codereview.chromium.org/2901503003/diff/1/ash/shell/lock_view.cc
File ash/shell/lock_view.cc (right):

https://codereview.chromium.org/2901503003/diff/1/ash/shell/lock_view.cc#newc...
ash/shell/lock_view.cc:37: return gfx::Size(500, 400);
set_preferred_size() instead?

https://codereview.chromium.org/2901503003/diff/1/ash/shell/panel_window.cc
File ash/shell/panel_window.cc (right):

https://codereview.chromium.org/2901503003/diff/1/ash/shell/panel_window.cc#n...
ash/shell/panel_window.cc:59: gfx::Size PanelWindow::CalculatePreferredSize()
const {
set_preferred_size?

https://codereview.chromium.org/2901503003/diff/1/ash/shell/widgets.cc
File ash/shell/widgets.cc (right):

https://codereview.chromium.org/2901503003/diff/1/ash/shell/widgets.cc#newcod...
ash/shell/widgets.cc:118: return gfx::Size(kWindowWidth, kWindowHeight);
set_preferred_size?

https://codereview.chromium.org/2901503003/diff/1/ash/shell/window_type_launc...
File ash/shell/window_type_launcher.cc (right):

https://codereview.chromium.org/2901503003/diff/1/ash/shell/window_type_launc...
ash/shell/window_type_launcher.cc:69: gfx::Size CalculatePreferredSize() const
override {
Ditto.

[Evan Stade, 2017-05-22 17:39:12]

Description was changed from

==========
Rename GetPreferredSize to CalculatePreferredSize in ash/

BUG=none
==========

to

==========
Rename GetPreferredSize to CalculatePreferredSize in ash/

Also remove the function completely where it makes the code simpler:
- FrameCaptionButton
- ExitWarningWidgetDelegateView
- UserCardView

BUG=none
==========

[Evan Stade, 2017-05-22 17:41:52]

On 2017/05/22 17:30:58, sky wrote:
> Is there a reason not to explicitly set the preferred size for the overrides
> that just hardcode a return value?

It's not my intention to change those right now unless it otherwise simplifies
things, e.g. allows us to remove the class. It doesn't seem like a huge win
when we already have other overrides. I've gone through and simplified the
places where we essentially reimplemented the set_preferred_size functionality.

[sky, 2017-05-22 21:02:23]

Ok, LGTM

[Evan Stade, 2017-05-22 21:18:21]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2017-05-22 21:19:03]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 21:52:27]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495487901310950,
"parent_rev": "a6cf82059b3d41ecbb1a6c72c5551b7a082ac345", "commit_rev":
"2c2e5748c8a040f8cf7bf6301052a964020fc694"}

[commit-bot: I haz the power, 2017-05-22 21:52:44]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495487901310950,
"parent_rev": "34085f14e27f3de4a2c3c6d18ee9bbf9a721b068", "commit_rev":
"f285a784f8a21236d5c17dc4576306844654ffee"}

[commit-bot: I haz the power, 2017-05-22 21:53:07]

Description was changed from

==========
Rename GetPreferredSize to CalculatePreferredSize in ash/

Also remove the function completely where it makes the code simpler:
- FrameCaptionButton
- ExitWarningWidgetDelegateView
- UserCardView

BUG=none
==========

to

==========
Rename GetPreferredSize to CalculatePreferredSize in ash/

Also remove the function completely where it makes the code simpler:
- FrameCaptionButton
- ExitWarningWidgetDelegateView
- UserCardView

BUG=none

Review-Url: https://codereview.chromium.org/2901503003
Cr-Commit-Position: refs/heads/master@{#473715}
Committed:
https://chromium.googlesource.com/chromium/src/+/f285a784f8a21236d5c17dc45763...
==========

[commit-bot: I haz the power, 2017-05-22 21:53:08]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f285a784f8a21236d5c17dc45763...