chromeos: Fix handling of null in NativeDisplayDelegate

chromeos: Fix handling of null in NativeDisplayDelegate

NativeDisplayDelegate::ConfigureDisplays() may be passed null. The
mojom didn't have the ? though and the code wasn't dealing
appropriately.

BUG=706589
TEST=none
R=rockot@chromium.org, tsepez@chromium.org

Review-Url: https://codereview.chromium.org/2901413004
Cr-Commit-Position: refs/heads/master@{#475041}
Committed: https://chromium.googlesource.com/chromium/src/+/ce00cf81df6d6949fb64023c486f23792ca131e8

[sky, 2017-05-25 22:40:56]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 22:41:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2017-05-26 00:38:28]

LGTM. This is probably an issue for another time, but I have to wonder if
DisplayMode shouldn't just allow copying and then we wouldn't have to typemap to
unique_ptr<DisplayMode> and it wouldn't need a weird Clone() interface.

[commit-bot: I haz the power, 2017-05-26 00:47:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 00:47:11]

Dry run: This issue passed the CQ dry run.

[sky, 2017-05-26 02:26:16]

On 2017/05/26 00:38:28, Ken Rockot(use gerrit already) wrote:
> LGTM. This is probably an issue for another time, but I have to wonder if
> DisplayMode shouldn't just allow copying and then we wouldn't have to typemap
to
> unique_ptr<DisplayMode> and it wouldn't need a weird Clone() interface.

I have to admit I'm not particularly familiar with this code. I ended up here
because I started hit segv because of calling Clone() on NULL. Even if it
supported copying directly we still have to deal with allowing null.

[Tom Sepez, 2017-05-26 16:38:03]

lgtm

[rjkroege, 2017-05-26 17:09:21]

(possibly useless comment) but DrmNativeDisplayDelegate::Configure would crash
if DisplayMode is null.

[sky, 2017-05-26 17:12:04]

Description was changed from

==========
chromeos: Fix handling of null in NativeDisplayDelegate

NativeDisplayDelegate::ConfigureDisplays() may be passed null. The
mojom didn't have the ? though and the code wasn't dealing
appropriately.

BUG=706589
TEST=none
R=rockot@chromium.org, tsepez@chromium.org
==========

to

==========
chromeos: Fix handling of null in NativeDisplayDelegate

NativeDisplayDelegate::ConfigureDisplays() may be passed null. The
mojom didn't have the ? though and the code wasn't dealing
appropriately.

BUG=706589
TEST=none
R=rockot@chromium.org, tsepez@chromium.org
==========

[sky, 2017-05-26 17:12:04]

sky@chromium.org changed reviewers:
+ kylechar@chromium.org

[sky, 2017-05-26 17:18:28]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2017-05-26 17:18:50]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 17:24:00]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495819108095370, "parent_rev":
"e66aa55947422665d6fddaad94610ac8fc271d79", "commit_rev":
"ce00cf81df6d6949fb64023c486f23792ca131e8"}

[commit-bot: I haz the power, 2017-05-26 17:24:16]

Description was changed from

==========
chromeos: Fix handling of null in NativeDisplayDelegate

NativeDisplayDelegate::ConfigureDisplays() may be passed null. The
mojom didn't have the ? though and the code wasn't dealing
appropriately.

BUG=706589
TEST=none
R=rockot@chromium.org, tsepez@chromium.org
==========

to

==========
chromeos: Fix handling of null in NativeDisplayDelegate

NativeDisplayDelegate::ConfigureDisplays() may be passed null. The
mojom didn't have the ? though and the code wasn't dealing
appropriately.

BUG=706589
TEST=none
R=rockot@chromium.org, tsepez@chromium.org

Review-Url: https://codereview.chromium.org/2901413004
Cr-Commit-Position: refs/heads/master@{#475041}
Committed:
https://chromium.googlesource.com/chromium/src/+/ce00cf81df6d6949fb64023c486f...
==========

[commit-bot: I haz the power, 2017-05-26 17:24:17]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ce00cf81df6d6949fb64023c486f...