Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2901403003: [Extensions Bindings] Update tabs tests to accept new error messages (Closed)

Created:
3 years, 7 months ago by Devlin
Modified:
3 years, 7 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, jbroman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions Bindings] Update tabs tests to accept new error messages Certain tabs API tests expect errors for passing invalid arguments. Update the tests to accept the errors from the native bindings system. BUG=653596 TEST=ExtensionApiTabTest.TabAudible --native-crx-bindings=1, ExtensionApiTabTest.TabMove --native-crx-bindings=1 Review-Url: https://codereview.chromium.org/2901403003 Cr-Commit-Position: refs/heads/master@{#474899} Committed: https://chromium.googlesource.com/chromium/src/+/4ff9a598e54fadca6b3a28177982c9767055936a

Patch Set 1 #

Total comments: 2

Patch Set 2 : lazyboys #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -11 lines) Patch
M chrome/test/data/extensions/api_test/tabs/basics/audible.js View 1 1 chunk +14 lines, -8 lines 0 comments Download
M chrome/test/data/extensions/api_test/tabs/basics/move.js View 1 1 chunk +13 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
Devlin
lazyboy@, mind taking a look? jbroman@, FYI.
3 years, 7 months ago (2017-05-25 19:27:23 UTC) #6
lazyboy
lgtm with one nit. Also CL description: s/TabAudible/TabMove https://codereview.chromium.org/2901403003/diff/1/chrome/test/data/extensions/api_test/tabs/basics/audible.js File chrome/test/data/extensions/api_test/tabs/basics/audible.js (right): https://codereview.chromium.org/2901403003/diff/1/chrome/test/data/extensions/api_test/tabs/basics/audible.js#newcode39 chrome/test/data/extensions/api_test/tabs/basics/audible.js:39: var ...
3 years, 7 months ago (2017-05-25 21:46:42 UTC) #7
Devlin
https://codereview.chromium.org/2901403003/diff/1/chrome/test/data/extensions/api_test/tabs/basics/audible.js File chrome/test/data/extensions/api_test/tabs/basics/audible.js (right): https://codereview.chromium.org/2901403003/diff/1/chrome/test/data/extensions/api_test/tabs/basics/audible.js#newcode39 chrome/test/data/extensions/api_test/tabs/basics/audible.js:39: var jsBindingsError = On 2017/05/25 21:46:42, lazyboy wrote: > ...
3 years, 7 months ago (2017-05-26 01:34:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2901403003/20001
3 years, 7 months ago (2017-05-26 01:35:59 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 03:30:25 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4ff9a598e54fadca6b3a28177982...

Powered by Google App Engine
This is Rietveld 408576698