Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1819)

Issue 2901393003: MIPS[64]: Fix deoptimizer generate table for large deoptimization tables (Closed)

Created:
3 years, 7 months ago by ivica.bogosavljevic
Modified:
3 years, 7 months ago
Reviewers:
miran.karic, dusan.simicic, miran.karic, neis, jaroslav.gorin
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS[64]: Fix deoptimizer generate table for large deoptimization tables Fix 233b6926e3ae29a4567b4c55bc1c1e96c07c1f92 With the introduction of upfront deopt table generation, case where deoptimization tables have more than 8000 entries become much more common and bugs started to appear. This CL fixes the issue, but it is far from perfect. We had to increase number of instruction per table entry from 2 to 3 in order to accommodate larger tables. TEST=mjsunit/array-sort,mjsunit/json,mjsunit/md5 BUG= Review-Url: https://codereview.chromium.org/2901393003 Cr-Commit-Position: refs/heads/master@{#45531} Committed: https://chromium.googlesource.com/v8/v8/+/601f1fdf8d4b9e527ab1e5c061803ef548ecfd93

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -44 lines) Patch
M src/mips/deoptimizer-mips.cc View 3 chunks +18 lines, -22 lines 1 comment Download
M src/mips64/deoptimizer-mips64.cc View 3 chunks +18 lines, -22 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
ivica.bogosavljevic
This fixes issue with the failure of some 400 tests. PTAL
3 years, 7 months ago (2017-05-25 13:47:42 UTC) #2
ivica.bogosavljevic
https://codereview.chromium.org/2901393003/diff/1/src/mips/deoptimizer-mips.cc File src/mips/deoptimizer-mips.cc (left): https://codereview.chromium.org/2901393003/diff/1/src/mips/deoptimizer-mips.cc#oldcode368 src/mips/deoptimizer-mips.cc:368: __ BranchShort(USE_DELAY_SLOT, &done_special); the issue appears here. we use ...
3 years, 7 months ago (2017-05-25 13:52:57 UTC) #5
dusan.simicic
LGTM
3 years, 7 months ago (2017-05-25 14:18:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2901393003/1
3 years, 7 months ago (2017-05-25 14:29:27 UTC) #10
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 7 months ago (2017-05-25 14:29:29 UTC) #12
miran.karic
lgtm
3 years, 7 months ago (2017-05-25 14:41:28 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2901393003/1
3 years, 7 months ago (2017-05-25 14:48:27 UTC) #16
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 14:52:36 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/601f1fdf8d4b9e527ab1e5c061803ef548e...

Powered by Google App Engine
This is Rietveld 408576698