Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2901393002: Create a new local context class. (Closed)

Created:
3 years, 6 months ago by Jia
Modified:
3 years, 6 months ago
Reviewers:
meade_UTC10, Bugs Nash
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Create a new local context class. CSSParserLocalContext represents local context for each property. Currently it only has one boolean field (use_alias_parsing), but it will be later extended to contain other info, such as whether the property is a longhand of a shorthand. BUG=668012 Review-Url: https://codereview.chromium.org/2901393002 Cr-Commit-Position: refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/b6460e24cf59f429d69de255538d0fc7a425ccf9

Patch Set 1 #

Patch Set 2 : Add a TODO item. #

Total comments: 1

Patch Set 3 : Add parameter name. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -0 lines) Patch
M third_party/WebKit/Source/core/css/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/parser/CSSParserLocalContext.h View 1 2 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/parser/CSSParserLocalContext.cpp View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
Jia
3 years, 6 months ago (2017-05-25 06:49:36 UTC) #2
Bugs Nash
On 2017/05/25 at 06:49:36, jiameng wrote: > Hm it seems strange having this class with ...
3 years, 6 months ago (2017-05-25 23:43:50 UTC) #3
Bugs Nash
On 2017/05/25 at 23:43:50, Bugs Nash wrote: > On 2017/05/25 at 06:49:36, jiameng wrote: > ...
3 years, 6 months ago (2017-05-25 23:44:56 UTC) #4
Bugs Nash
On 2017/05/25 at 23:44:56, Bugs Nash wrote: > On 2017/05/25 at 23:43:50, Bugs Nash wrote: ...
3 years, 6 months ago (2017-05-26 00:17:29 UTC) #5
Jia
On 2017/05/26 00:17:29, Bugs Nash wrote: > On 2017/05/25 at 23:44:56, Bugs Nash wrote: > ...
3 years, 6 months ago (2017-05-26 00:21:46 UTC) #6
Jia
meade@chromium.org: Please review changes in
3 years, 6 months ago (2017-05-26 00:22:05 UTC) #8
meade_UTC10
lgtm with nit https://codereview.chromium.org/2901393002/diff/20001/third_party/WebKit/Source/core/css/parser/CSSParserLocalContext.h File third_party/WebKit/Source/core/css/parser/CSSParserLocalContext.h (right): https://codereview.chromium.org/2901393002/diff/20001/third_party/WebKit/Source/core/css/parser/CSSParserLocalContext.h#newcode20 third_party/WebKit/Source/core/css/parser/CSSParserLocalContext.h:20: explicit CSSParserLocalContext(bool); I'd keep the name ...
3 years, 6 months ago (2017-05-26 00:29:23 UTC) #9
Jia
On 2017/05/26 00:29:23, meade_UTC10 wrote: > lgtm with nit > > https://codereview.chromium.org/2901393002/diff/20001/third_party/WebKit/Source/core/css/parser/CSSParserLocalContext.h > File third_party/WebKit/Source/core/css/parser/CSSParserLocalContext.h ...
3 years, 6 months ago (2017-05-26 00:32:56 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2901393002/40001
3 years, 6 months ago (2017-05-26 03:23:07 UTC) #17
commit-bot: I haz the power
3 years, 6 months ago (2017-05-26 03:28:51 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b6460e24cf59f429d69de255538d...

Powered by Google App Engine
This is Rietveld 408576698