Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issue 2901383007: Don't create parallel request until download file is initialized (Closed)

Created:
3 years, 6 months ago by qinmin
Modified:
3 years, 6 months ago
CC:
chromium-reviews, jam, David Trainor- moved to gerrit, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't create parallel request until download file is initialized Chrome should wait until download file is initialized before creating parallel requests. With this CL, it also makes more sense for DownloadJob to own download file. I will do that in follow up CLs. BUG=726487 Review-Url: https://codereview.chromium.org/2901383007 Cr-Commit-Position: refs/heads/master@{#475176} Committed: https://chromium.googlesource.com/chromium/src/+/5555a916120874ae028efea267e9ef7077f1e0df

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -43 lines) Patch
M content/browser/download/download_item_impl.h View 2 chunks +0 lines, -6 lines 0 comments Download
M content/browser/download/download_item_impl.cc View 2 chunks +4 lines, -20 lines 0 comments Download
M content/browser/download/download_job.h View 4 chunks +13 lines, -2 lines 0 comments Download
M content/browser/download/download_job.cc View 2 chunks +22 lines, -4 lines 0 comments Download
M content/browser/download/download_job_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/download/download_job_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/download/mock_download_job.h View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/download/parallel_download_job.h View 1 chunk +5 lines, -1 line 0 comments Download
M content/browser/download/parallel_download_job.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M content/browser/download/parallel_download_job_unittest.cc View 6 chunks +65 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
qinmin
PTAL
3 years, 6 months ago (2017-05-26 18:08:56 UTC) #2
xingliu
lgtm
3 years, 6 months ago (2017-05-26 22:13:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2901383007/1
3 years, 6 months ago (2017-05-26 23:05:01 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-05-26 23:16:04 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5555a916120874ae028efea267e9...

Powered by Google App Engine
This is Rietveld 408576698