Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2901383005: [i18n] domain reliability internals to $i18n (Closed)

Created:
3 years, 7 months ago by dschuyler
Modified:
3 years, 7 months ago
Reviewers:
tommycli
CC:
chromium-reviews, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[i18n] domain reliability internals to $i18n This Cl removes the i18n-content and i18n-values replacing them with $i18n{} replacements. The <h1> title was removed because afaict it was not being set and therefore empty. Side note: There is English in the page and it appears to be an internal-only developer page, so it's reasonable think that the i18n title wasn't being set. BUG=677338 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2901383005 Cr-Commit-Position: refs/heads/master@{#475060} Committed: https://chromium.googlesource.com/chromium/src/+/aa4fdf26a8bb80fc51e06a3f7f8ce281fee23f35

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/resources/domain_reliability_internals.html View 2 chunks +1 line, -2 lines 1 comment Download

Messages

Total messages: 13 (9 generated)
dschuyler
https://codereview.chromium.org/2901383005/diff/1/chrome/browser/resources/domain_reliability_internals.html File chrome/browser/resources/domain_reliability_internals.html (left): https://codereview.chromium.org/2901383005/diff/1/chrome/browser/resources/domain_reliability_internals.html#oldcode15 chrome/browser/resources/domain_reliability_internals.html:15: <h1 i18n-content="title"></h1> The <h1> title was removed because afaict ...
3 years, 7 months ago (2017-05-25 23:28:15 UTC) #5
tommycli
lgtm
3 years, 7 months ago (2017-05-25 23:37:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2901383005/1
3 years, 7 months ago (2017-05-26 18:10:00 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 18:15:36 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/aa4fdf26a8bb80fc51e06a3f7f8c...

Powered by Google App Engine
This is Rietveld 408576698