Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1949)

Unified Diff: chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h

Issue 2901383002: Buffer cross frame paint timing updates. (Closed)
Patch Set: factor WeakMockTimer into a common location. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h
diff --git a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h b/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h
index 5d4cd7daacc48baf76cdcf207707240323f5dc9d..54a3264b9fa0ea372cb1000273673ef5c1f29827 100644
--- a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h
+++ b/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h
@@ -6,9 +6,12 @@
#define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_PAGE_LOAD_METRICS_OBSERVER_TEST_HARNESS_H_
#include "base/macros.h"
+#include "base/memory/weak_ptr.h"
#include "base/test/histogram_tester.h"
+#include "base/timer/mock_timer.h"
Charlie Harrison 2017/05/30 14:49:07 clean up includes, I think you only need weak_mock
Bryan McQuade 2017/05/30 15:30:22 done
#include "chrome/browser/page_load_metrics/metrics_web_contents_observer.h"
#include "chrome/browser/page_load_metrics/page_load_tracker.h"
+#include "chrome/common/page_load_metrics/test/weak_mock_timer.h"
#include "chrome/common/url_constants.h"
#include "chrome/test/base/chrome_render_view_host_test_harness.h"
#include "content/public/test/web_contents_tester.h"
@@ -21,7 +24,8 @@ namespace page_load_metrics {
// an observer, override RegisterObservers and call tracker->AddObserver. This
// will attach the observer to all main frame navigations.
class PageLoadMetricsObserverTestHarness
- : public ChromeRenderViewHostTestHarness {
+ : public ChromeRenderViewHostTestHarness,
+ public WeakMockTimerProvider {
public:
PageLoadMetricsObserverTestHarness();
~PageLoadMetricsObserverTestHarness() override;

Powered by Google App Engine
This is Rietveld 408576698