Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Side by Side Diff: chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h

Issue 2901383002: Buffer cross frame paint timing updates. (Closed)
Patch Set: factor WeakMockTimer into a common location. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_PAGE_LOAD_METRICS_OBSERVER_TE ST_HARNESS_H_ 5 #ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_PAGE_LOAD_METRICS_OBSERVER_TE ST_HARNESS_H_
6 #define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_PAGE_LOAD_METRICS_OBSERVER_TE ST_HARNESS_H_ 6 #define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_PAGE_LOAD_METRICS_OBSERVER_TE ST_HARNESS_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/memory/weak_ptr.h"
9 #include "base/test/histogram_tester.h" 10 #include "base/test/histogram_tester.h"
11 #include "base/timer/mock_timer.h"
Charlie Harrison 2017/05/30 14:49:07 clean up includes, I think you only need weak_mock
Bryan McQuade 2017/05/30 15:30:22 done
10 #include "chrome/browser/page_load_metrics/metrics_web_contents_observer.h" 12 #include "chrome/browser/page_load_metrics/metrics_web_contents_observer.h"
11 #include "chrome/browser/page_load_metrics/page_load_tracker.h" 13 #include "chrome/browser/page_load_metrics/page_load_tracker.h"
14 #include "chrome/common/page_load_metrics/test/weak_mock_timer.h"
12 #include "chrome/common/url_constants.h" 15 #include "chrome/common/url_constants.h"
13 #include "chrome/test/base/chrome_render_view_host_test_harness.h" 16 #include "chrome/test/base/chrome_render_view_host_test_harness.h"
14 #include "content/public/test/web_contents_tester.h" 17 #include "content/public/test/web_contents_tester.h"
15 #include "third_party/WebKit/public/platform/WebInputEvent.h" 18 #include "third_party/WebKit/public/platform/WebInputEvent.h"
16 #include "ui/base/page_transition_types.h" 19 #include "ui/base/page_transition_types.h"
17 20
18 namespace page_load_metrics { 21 namespace page_load_metrics {
19 22
20 // This class can be used to drive tests of PageLoadMetricsObservers. To hook up 23 // This class can be used to drive tests of PageLoadMetricsObservers. To hook up
21 // an observer, override RegisterObservers and call tracker->AddObserver. This 24 // an observer, override RegisterObservers and call tracker->AddObserver. This
22 // will attach the observer to all main frame navigations. 25 // will attach the observer to all main frame navigations.
23 class PageLoadMetricsObserverTestHarness 26 class PageLoadMetricsObserverTestHarness
24 : public ChromeRenderViewHostTestHarness { 27 : public ChromeRenderViewHostTestHarness,
28 public WeakMockTimerProvider {
25 public: 29 public:
26 PageLoadMetricsObserverTestHarness(); 30 PageLoadMetricsObserverTestHarness();
27 ~PageLoadMetricsObserverTestHarness() override; 31 ~PageLoadMetricsObserverTestHarness() override;
28 32
29 // Helper that fills in any timing fields that MWCO requires but that are 33 // Helper that fills in any timing fields that MWCO requires but that are
30 // currently missing. 34 // currently missing.
31 static void PopulateRequiredTimingFields(mojom::PageLoadTiming* inout_timing); 35 static void PopulateRequiredTimingFields(mojom::PageLoadTiming* inout_timing);
32 36
33 void SetUp() override; 37 void SetUp() override;
34 38
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 private: 85 private:
82 base::HistogramTester histogram_tester_; 86 base::HistogramTester histogram_tester_;
83 MetricsWebContentsObserver* observer_; 87 MetricsWebContentsObserver* observer_;
84 88
85 DISALLOW_COPY_AND_ASSIGN(PageLoadMetricsObserverTestHarness); 89 DISALLOW_COPY_AND_ASSIGN(PageLoadMetricsObserverTestHarness);
86 }; 90 };
87 91
88 } // namespace page_load_metrics 92 } // namespace page_load_metrics
89 93
90 #endif // CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_PAGE_LOAD_METRICS_OBSERVER _TEST_HARNESS_H_ 94 #endif // CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_PAGE_LOAD_METRICS_OBSERVER _TEST_HARNESS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698