Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2901373002: Add UseCounter for SpeechRecognition (Closed)

Created:
3 years, 7 months ago by Rick Byers
Modified:
3 years, 7 months ago
Reviewers:
lunalu1, iclelland
CC:
asvitkine+watch_chromium.org, blink-reviews, blink-reviews-frames_chromium.org, chromium-reviews, haraken
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add UseCounter for SpeechRecognition BUG=726188 Review-Url: https://codereview.chromium.org/2901373002 Cr-Commit-Position: refs/heads/master@{#475134} Committed: https://chromium.googlesource.com/chromium/src/+/793a817301622f653c43ec9ad8869b4b1e373b0a

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/speech/SpeechRecognition.idl View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/enums.xml View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 23 (12 generated)
Rick Byers
lunalu@ PTAL From a quick scan of the API docs it looks like the only ...
3 years, 7 months ago (2017-05-25 02:11:17 UTC) #2
lunalu1
lgtm
3 years, 7 months ago (2017-05-25 18:51:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2901373002/1
3 years, 7 months ago (2017-05-25 18:52:27 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 7 months ago (2017-05-25 18:52:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2901373002/1
3 years, 7 months ago (2017-05-25 19:55:25 UTC) #9
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 7 months ago (2017-05-25 19:55:26 UTC) #11
iclelland
RS LGTM
3 years, 7 months ago (2017-05-26 14:05:57 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2901373002/1
3 years, 7 months ago (2017-05-26 14:06:29 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/219849) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 7 months ago (2017-05-26 14:08:21 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2901373002/20001
3 years, 7 months ago (2017-05-26 19:00:09 UTC) #20
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 21:22:54 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/793a817301622f653c43ec9ad886...

Powered by Google App Engine
This is Rietveld 408576698