Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(852)

Issue 2901333003: [WebView] Flatten lib/main to lib (Closed)

Created:
3 years, 7 months ago by Shimi Zhang
Modified:
3 years, 7 months ago
Reviewers:
Ted C, Torne
CC:
chromium-reviews, android-webview-reviews_chromium.org, sgurun-gerrit only
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[WebView] Flatten lib/main to lib Moves all files under lib/main to lib/ since two levels here didn't make sense. With some git cl format. BUG=716604 Review-Url: https://codereview.chromium.org/2901333003 Cr-Commit-Position: refs/heads/master@{#474736} Committed: https://chromium.googlesource.com/chromium/src/+/323e56e432cb28e97150b1b2a36225b751e3c398

Patch Set 1 #

Total comments: 4

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -485 lines) Patch
M android_webview/BUILD.gn View 3 chunks +6 lines, -6 lines 0 comments Download
A + android_webview/lib/aw_main_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + android_webview/lib/aw_main_delegate.cc View 1 5 chunks +6 lines, -10 lines 0 comments Download
D android_webview/lib/main/aw_main_delegate.h View 1 chunk +0 lines, -63 lines 0 comments Download
D android_webview/lib/main/aw_main_delegate.cc View 1 chunk +0 lines, -267 lines 0 comments Download
D android_webview/lib/main/webview_entry_point.cc View 1 chunk +0 lines, -19 lines 0 comments Download
D android_webview/lib/main/webview_jni_onload.h View 1 chunk +0 lines, -20 lines 0 comments Download
D android_webview/lib/main/webview_jni_onload.cc View 1 chunk +0 lines, -60 lines 0 comments Download
D android_webview/lib/main/webview_tests.cc View 1 chunk +0 lines, -21 lines 0 comments Download
A + android_webview/lib/webview_entry_point.cc View 1 chunk +1 line, -1 line 0 comments Download
A + android_webview/lib/webview_jni_onload.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + android_webview/lib/webview_jni_onload.cc View 3 chunks +8 lines, -10 lines 0 comments Download
A + android_webview/lib/webview_tests.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M android_webview/test/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/android/monochrome_entry_point.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (13 generated)
Shimi Zhang
torne@, PTAL, thanks!
3 years, 7 months ago (2017-05-25 17:00:52 UTC) #7
Torne
LGTM with a couple nits Thanks for doing this, I can cross this off my ...
3 years, 7 months ago (2017-05-25 17:04:16 UTC) #8
Shimi Zhang
Thanks for catching, I should be more careful though.. :P https://codereview.chromium.org/2901333003/diff/1/android_webview/lib/aw_main_delegate.cc File android_webview/lib/aw_main_delegate.cc (right): https://codereview.chromium.org/2901333003/diff/1/android_webview/lib/aw_main_delegate.cc#newcode77 ...
3 years, 7 months ago (2017-05-25 17:40:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2901333003/20001
3 years, 7 months ago (2017-05-25 17:43:51 UTC) #12
Shimi Zhang
tedchoc@, could you PTAL for chrome/browser/android/monochrome_entry_point.cc, thanks!
3 years, 7 months ago (2017-05-25 17:51:13 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/447603)
3 years, 7 months ago (2017-05-25 17:53:34 UTC) #16
Ted C
On 2017/05/25 17:53:34, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 7 months ago (2017-05-25 17:57:59 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2901333003/20001
3 years, 7 months ago (2017-05-25 17:59:12 UTC) #19
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 19:00:14 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/323e56e432cb28e97150b1b2a362...

Powered by Google App Engine
This is Rietveld 408576698