Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 2901333002: Revert "Stop source and fire MediaStreamTrack ended event if missing audio input callbacks are dete… (Closed)

Created:
3 years, 7 months ago by emircan
Modified:
3 years, 7 months ago
Reviewers:
Henrik Grunell
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, imcheng+watch_chromium.org, feature-media-reviews_chromium.org, posciak+watch_chromium.org, chfremer+watch_chromium.org, jam, avayvod+watch_chromium.org, darin-cc_chromium.org, asvitkine+watch_chromium.org, jasonroberts+watch_google.com, xjz+watch_chromium.org, mfoltz+watch_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Stop source and fire MediaStreamTrack ended event if missing audio input callbacks are detected." This reverts commit dc44616c932d390c6ee11c2eb5931d51e7df91a7. Reason for revert: This seems to break webrtc tests on Mac, see https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/builds/68150. NOTRY=true NOPRESUBMIT=true TBR=grunnell@chromium.org Review-Url: https://codereview.chromium.org/2901333002 Cr-Commit-Position: refs/heads/master@{#474412} Committed: https://chromium.googlesource.com/chromium/src/+/e918df21b77ee71c416a92a91f9b4d65f609d7c0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -130 lines) Patch
M content/renderer/media/local_media_stream_audio_source.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M media/audio/audio_input_device.h View 3 chunks +0 lines, -31 lines 0 comments Download
M media/audio/audio_input_device.cc View 9 chunks +7 lines, -83 lines 0 comments Download
M tools/metrics/histograms/enums.xml View 1 chunk +0 lines, -5 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2901333002/1
3 years, 7 months ago (2017-05-24 20:48:00 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 20:48:50 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e918df21b77ee71c416a92a91f9b...

Powered by Google App Engine
This is Rietveld 408576698