Add virtual key code entry to support Command + Shift + [\] tab switching in some Chinese IME

Add virtual key code entry to support Command + Shift + [\] tab switching in some Chinese IME


When using Pinyin-IME, pressing Command + Shift + [ (or ]) does not lead to the
same NSEvent as those of other keyboard types. Therefore, when such IMEs are active
these standard key combinations do not work.

This CL will add two more rows to the list of global Mac shortkeys such that the
command lookup would fall back to the new entries which are based on virtual key
codes.

BUG=708895
Review-Url: https://codereview.chromium.org/2901293004
Cr-Commit-Position: refs/heads/master@{#477666}
Committed: https://chromium.googlesource.com/chromium/src/+/90b1637839bc498f3de67b66ca0a4c8e250929fb

[EhsanK, 2017-05-24 22:02:54]

The CQ bit was checked by ekaramad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 22:04:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[EhsanK, 2017-05-24 22:07:40]

Description was changed from

==========
Add virtual key code entry to for {/} in cocoa shortcuts

Add an try in window keyboard shortcut table so that Command+Shift+{/} are
recognized when using Pinyin IME.

BUG=708895
==========

to

==========
Add virtual key code entry to for {/} in cocoa shortcuts

Add an try in window keyboard shortcut table so that Command+Shift+{/} are
recognized when using Pinyin IME.

BUG=708895
==========

[commit-bot: I haz the power, 2017-05-24 22:32:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 22:32:58]

Dry run: This issue passed the CQ dry run.

[EhsanK, 2017-06-06 21:36:02]

Description was changed from

==========
Add virtual key code entry to for {/} in cocoa shortcuts

Add an try in window keyboard shortcut table so that Command+Shift+{/} are
recognized when using Pinyin IME.

BUG=708895
==========

to

==========
Add virtual key code entry to support Command + Shift + [\] tab switching in
some Chinese IME


When using Pinyin-IME, pressing Command + Shift + [ (or ]) does not lead to the
same NSEvent as those of other keyboard types. Therefore, when such IMEs are
active
these standard key combinations do not work.

This CL will add two more rows to the list of global Mac shortkeys such that the
command lookup would fall back to the new entries which are based on virtual key
codes.

BUG=708895
==========

[EhsanK, 2017-06-06 21:37:04]

ekaramad@chromium.org changed reviewers:
+ avi@chromium.org

[EhsanK, 2017-06-06 21:37:05]

Hello Avi, PTAL.

Not sure if this is the best fix. Also I was not sure how to deal with the
formatting in the file so I just added another round of spaces (now each line is
longer than 80).

[Avi (use Gerrit), 2017-06-06 22:53:23]

LGTM

I'm not sure I'm the best reviewer, but I'm not sure if there's anyone else
better.

[EhsanK, 2017-06-07 15:15:17]

On 2017/06/06 22:53:23, Avi (ping after 24h) wrote:
> LGTM
> 
> I'm not sure I'm the best reviewer, but I'm not sure if there's anyone else
> better.

Thanks Avi! From the bug comments I figured no one is sure who owns this part of
code.

I will try to CQ today.

[EhsanK, 2017-06-07 15:42:55]

The CQ bit was checked by ekaramad@chromium.org

[commit-bot: I haz the power, 2017-06-07 15:43:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 16:04:27]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496850175737280,
"parent_rev": "d9374411781498797ca4bc987475b5e483018d49", "commit_rev":
"90b1637839bc498f3de67b66ca0a4c8e250929fb"}

[commit-bot: I haz the power, 2017-06-07 16:04:37]

Description was changed from

==========
Add virtual key code entry to support Command + Shift + [\] tab switching in
some Chinese IME


When using Pinyin-IME, pressing Command + Shift + [ (or ]) does not lead to the
same NSEvent as those of other keyboard types. Therefore, when such IMEs are
active
these standard key combinations do not work.

This CL will add two more rows to the list of global Mac shortkeys such that the
command lookup would fall back to the new entries which are based on virtual key
codes.

BUG=708895
==========

to

==========
Add virtual key code entry to support Command + Shift + [\] tab switching in
some Chinese IME


When using Pinyin-IME, pressing Command + Shift + [ (or ]) does not lead to the
same NSEvent as those of other keyboard types. Therefore, when such IMEs are
active
these standard key combinations do not work.

This CL will add two more rows to the list of global Mac shortkeys such that the
command lookup would fall back to the new entries which are based on virtual key
codes.

BUG=708895

Review-Url: https://codereview.chromium.org/2901293004
Cr-Commit-Position: refs/heads/master@{#477666}
Committed:
https://chromium.googlesource.com/chromium/src/+/90b1637839bc498f3de67b66ca0a...
==========

[commit-bot: I haz the power, 2017-06-07 16:04:39]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/90b1637839bc498f3de67b66ca0a...