chrome/browser/extensions/api/preference/preference_apitest.cc - Issue 290123003: Exposes passwordSavingEnabled API from chrome privacy preference extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/preference/preference_apitest.cc

Issue 290123003: Exposes passwordSavingEnabled API from chrome privacy preference extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update code as per Bernhard's review comments. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/preference/preference_api.cc ('k') | chrome/common/extensions/api/privacy.json » ('j') | chrome/common/extensions/api/privacy.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/preference/preference_apitest.cc

diff --git a/chrome/browser/extensions/api/preference/preference_apitest.cc b/chrome/browser/extensions/api/preference/preference_apitest.cc

index 5a9c2445d9830fd4be47b8bd6a251e032e23e1d5..3a75f739500ab04c70439c169a5cd75c391142a4 100644

--- a/chrome/browser/extensions/api/preference/preference_apitest.cc

+++ b/chrome/browser/extensions/api/preference/preference_apitest.cc

@@ -41,6 +41,8 @@ class ExtensionPreferenceApiTest : public ExtensionApiTest {

EXPECT_TRUE(prefs->GetBoolean(prefs::kEnableReferrers));

EXPECT_TRUE(prefs->GetBoolean(prefs::kEnableTranslate));

EXPECT_TRUE(prefs->GetBoolean(prefs::kNetworkPredictionEnabled));

+ EXPECT_TRUE(prefs->GetBoolean(

+ password_manager::prefs::kPasswordManagerEnabled));

EXPECT_TRUE(prefs->GetBoolean(prefs::kSafeBrowsingEnabled));

EXPECT_TRUE(prefs->GetBoolean(prefs::kSearchSuggestEnabled));

}

@@ -58,6 +60,8 @@ class ExtensionPreferenceApiTest : public ExtensionApiTest {

EXPECT_FALSE(prefs->GetBoolean(prefs::kEnableReferrers));

EXPECT_FALSE(prefs->GetBoolean(prefs::kEnableTranslate));

EXPECT_FALSE(prefs->GetBoolean(prefs::kNetworkPredictionEnabled));

+ EXPECT_FALSE(prefs->GetBoolean(

+ password_manager::prefs::kPasswordManagerEnabled));

EXPECT_FALSE(prefs->GetBoolean(prefs::kSafeBrowsingEnabled));

EXPECT_FALSE(prefs->GetBoolean(prefs::kSearchSuggestEnabled));

}

@@ -103,6 +107,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionPreferenceApiTest, MAYBE_Standard) {

prefs->SetBoolean(prefs::kEnableReferrers, false);

prefs->SetBoolean(prefs::kEnableTranslate, false);

prefs->SetBoolean(prefs::kNetworkPredictionEnabled, false);

+ prefs->SetBoolean(password_manager::prefs::kPasswordManagerEnabled, false);

prefs->SetBoolean(prefs::kSafeBrowsingEnabled, false);

prefs->SetBoolean(prefs::kSearchSuggestEnabled, false);