chrome/browser/extensions/api/preference/preference_api.cc - Issue 290123003: Exposes passwordSavingEnabled API from chrome privacy preference extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/preference/preference_api.cc

Issue 290123003: Exposes passwordSavingEnabled API from chrome privacy preference extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update code as per Bernhard's review comments. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/preference/preference_api.cc

diff --git a/chrome/browser/extensions/api/preference/preference_api.cc b/chrome/browser/extensions/api/preference/preference_api.cc

index 2f9d89eeecbd5710c0967725f7ec12cf7f160dfb..2fecaff52211f41ad30ccbf913c32ce661c1c40b 100644

--- a/chrome/browser/extensions/api/preference/preference_api.cc

+++ b/chrome/browser/extensions/api/preference/preference_api.cc

@@ -66,8 +66,6 @@ const char kConversionErrorMessage[] =

"properly.";

PrefMappingEntry kPrefMapping[] = {

- {"protectedContentEnabled", prefs::kEnableDRM, APIPermission::kPrivacy,

- APIPermission::kPrivacy},

{"alternateErrorPagesEnabled", prefs::kAlternateErrorPagesEnabled,

APIPermission::kPrivacy, APIPermission::kPrivacy},

{"autofillEnabled", autofill::prefs::kAutofillEnabled,

@@ -76,6 +74,10 @@ PrefMappingEntry kPrefMapping[] = {

APIPermission::kPrivacy, APIPermission::kPrivacy},

{"networkPredictionEnabled", prefs::kNetworkPredictionEnabled,

APIPermission::kPrivacy, APIPermission::kPrivacy},

+ {"passwordManagerEnabled", password_manager::prefs::kPasswordManagerEnabled,

+ APIPermission::kPrivacy, APIPermission::kPrivacy},

+ {"protectedContentEnabled", prefs::kEnableDRM, APIPermission::kPrivacy,

+ APIPermission::kPrivacy},

{"proxy", prefs::kProxy, APIPermission::kProxy, APIPermission::kProxy},

{"referrersEnabled", prefs::kEnableReferrers, APIPermission::kPrivacy,

APIPermission::kPrivacy},

« no previous file with comments | « no previous file | chrome/browser/extensions/api/preference/preference_apitest.cc » ('j') | chrome/common/extensions/api/privacy.json » ('J')