Componentize safe_browsing: factor out SafeBrowsingURLRequestContextGetter.

Componentize safe_browsing: factor out SafeBrowsingURLRequestContextGetter.

Factor out SafeBrowsingURLRequestContextGetter from safe_browsing_service
and move it as a separate class into components/safe_browsing/browser/.
This patch also ensures that it's possible to provide a custom "user data
directory" upon construction.

This refactoring allows for the SafeBrowsingURLRequestContextGetter and its
dedicated cookie store to be resused in the Android WebView implementation.

Design doc: https://goo.gl/TfoY9K, section 2.

BUG=700351, 688629
TBR=pauljensen@chromium.org

Review-Url: https://codereview.chromium.org/2901213004
Cr-Commit-Position: refs/heads/master@{#474636}
Committed: https://chromium.googlesource.com/chromium/src/+/b00d167d8b2d7a51814f748585860ea510744a2c

[timvolodine, 2017-05-24 12:36:59]

The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 12:37:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[timvolodine, 2017-05-24 13:59:00]

The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 13:59:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[timvolodine, 2017-05-24 15:33:41]

timvolodine@chromium.org changed reviewers:
+ jialiul@chromium.org

[timvolodine, 2017-05-24 15:33:41]

jialiul@: please take a look.

+cc:nparker@

[commit-bot: I haz the power, 2017-05-24 15:53:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 15:53:50]

Dry run: This issue passed the CQ dry run.

[Jialiu Lin, 2017-05-24 21:42:32]

LGTM Thanks!

https://codereview.chromium.org/2901213004/diff/60001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/safe_browsing_service.cc (right):

https://codereview.chromium.org/2901213004/diff/60001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/safe_browsing_service.cc:51: #include
"net/url_request/url_request_context_getter.h"
nit: Do you still need this include?

[timvolodine, 2017-05-25 13:01:05]

thanks for the review!

https://codereview.chromium.org/2901213004/diff/60001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/safe_browsing_service.cc (right):

https://codereview.chromium.org/2901213004/diff/60001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/safe_browsing_service.cc:51: #include
"net/url_request/url_request_context_getter.h"
On 2017/05/24 21:42:31, Jialiu Lin wrote:
> nit: Do you still need this include?

The URLRequestContextGetter is still used in 2 places in this file..

[timvolodine, 2017-05-25 13:01:15]

The CQ bit was checked by timvolodine@chromium.org

[commit-bot: I haz the power, 2017-05-25 13:01:23]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 13:08:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 13:08:26]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[timvolodine, 2017-05-25 13:18:20]

timvolodine@chromium.org changed reviewers:
+ pauljensen@chromium.org

[timvolodine, 2017-05-25 13:18:21]

+pauljensen@ because presubmit requires this due to DEPS change:

'+net/cookies',
'+net/extras',
'+net/ssl',

[timvolodine, 2017-05-25 13:18:49]

Description was changed from

==========
Componentize safe_browsing: factor out SafeBrowsingURLRequestContextGetter.

Factor out SafeBrowsingURLRequestContextGetter from safe_browsing_service
and move it as a separate class into components/safe_browsing/browser/.
This patch also ensures that it's possible to provide a custom "user data
directory" upon construction.

This refactoring allows for the SafeBrowsingURLRequestContextGetter and its
dedicated cookie store to be resused in the Android WebView implementation.

Design doc: https://goo.gl/TfoY9K, section 2.

BUG=700351, 688629
==========

to

==========
Componentize safe_browsing: factor out SafeBrowsingURLRequestContextGetter.

Factor out SafeBrowsingURLRequestContextGetter from safe_browsing_service
and move it as a separate class into components/safe_browsing/browser/.
This patch also ensures that it's possible to provide a custom "user data
directory" upon construction.

This refactoring allows for the SafeBrowsingURLRequestContextGetter and its
dedicated cookie store to be resused in the Android WebView implementation.

Design doc: https://goo.gl/TfoY9K, section 2.

BUG=700351, 688629
TBR=pauljensen@chromium.org
==========

[timvolodine, 2017-05-25 13:19:25]

actually adding TBR=pauljensen@ as this is a refactoring

[timvolodine, 2017-05-25 13:19:30]

The CQ bit was checked by timvolodine@chromium.org

[commit-bot: I haz the power, 2017-05-25 13:19:45]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 13:23:43]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495718370963620,
"parent_rev": "000cea89869e0276d886fe541b3ff050aba9527f", "commit_rev":
"b00d167d8b2d7a51814f748585860ea510744a2c"}

[commit-bot: I haz the power, 2017-05-25 13:23:54]

Description was changed from

==========
Componentize safe_browsing: factor out SafeBrowsingURLRequestContextGetter.

Factor out SafeBrowsingURLRequestContextGetter from safe_browsing_service
and move it as a separate class into components/safe_browsing/browser/.
This patch also ensures that it's possible to provide a custom "user data
directory" upon construction.

This refactoring allows for the SafeBrowsingURLRequestContextGetter and its
dedicated cookie store to be resused in the Android WebView implementation.

Design doc: https://goo.gl/TfoY9K, section 2.

BUG=700351, 688629
TBR=pauljensen@chromium.org
==========

to

==========
Componentize safe_browsing: factor out SafeBrowsingURLRequestContextGetter.

Factor out SafeBrowsingURLRequestContextGetter from safe_browsing_service
and move it as a separate class into components/safe_browsing/browser/.
This patch also ensures that it's possible to provide a custom "user data
directory" upon construction.

This refactoring allows for the SafeBrowsingURLRequestContextGetter and its
dedicated cookie store to be resused in the Android WebView implementation.

Design doc: https://goo.gl/TfoY9K, section 2.

BUG=700351, 688629
TBR=pauljensen@chromium.org

Review-Url: https://codereview.chromium.org/2901213004
Cr-Commit-Position: refs/heads/master@{#474636}
Committed:
https://chromium.googlesource.com/chromium/src/+/b00d167d8b2d7a51814f74858586...
==========

[commit-bot: I haz the power, 2017-05-25 13:23:55]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/b00d167d8b2d7a51814f74858586...

[pauljensen, 2017-05-25 13:41:02]

On 2017/05/25 13:19:25, timvolodine wrote:
> actually adding TBR=pauljensen@ as this is a refactoring

My reading of the acceptable use of TBR does not include refactoring of a
non-mechanical nature:
https://chromium.googlesource.com/chromium/src/+/master/docs/code_reviews.md#...

[timvolodine, 2017-05-25 15:08:43]

On 2017/05/25 13:41:02, pauljensen wrote:
> On 2017/05/25 13:19:25, timvolodine wrote:
> > actually adding TBR=pauljensen@ as this is a refactoring
> 
> My reading of the acceptable use of TBR does not include refactoring of a
> non-mechanical nature:
>
https://chromium.googlesource.com/chromium/src/+/master/docs/code_reviews.md#...

I was assuming the net/ DEPS changes were sufficiently mechanical to warrant a
TBR in this case. Apologies if this came over as premature, let me know if there
are any comments. thanks!