Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2901183002: Do not send repeated Expect-CT reports to the same host+port (Closed)

Created:
3 years, 7 months ago by estark
Modified:
3 years, 7 months ago
Reviewers:
mattm
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not send repeated Expect-CT reports to the same host+port To avoid duplicate reports, this CL adds an ExpiringCache, keyed by request hostname+port, to not send repeated Expect-CT reports. As noted in a comment, it's possible that the same host+port could generate legitimately different Expect-CT reports and it could be useful for the server operator to receive both of them. However, this seems unlikely to happen in practice. In a future refactor in which we move the Expect-CT reporting code into //net, it would be easier to use more of the report contents as the cache key (so that meaningfully different reports would not share a cache key), but keying by host+port should suffice for now. BUG=679012 Review-Url: https://codereview.chromium.org/2901183002 Cr-Commit-Position: refs/heads/master@{#474927} Committed: https://chromium.googlesource.com/chromium/src/+/6952c722b2c48bcc634950d6cbf171083b1fea53

Patch Set 1 #

Patch Set 2 : fix comment typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -18 lines) Patch
M net/http/transport_security_state.h View 1 4 chunks +19 lines, -2 lines 0 comments Download
M net/http/transport_security_state.cc View 8 chunks +49 lines, -16 lines 0 comments Download
M net/http/transport_security_state_unittest.cc View 2 chunks +117 lines, -0 lines 0 comments Download
M net/socket/ssl_client_socket_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
estark
mattm, PTAL? Thanks!
3 years, 7 months ago (2017-05-23 23:47:09 UTC) #6
mattm
lgtm
3 years, 7 months ago (2017-05-25 19:48:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2901183002/20001
3 years, 7 months ago (2017-05-25 20:21:25 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/303402)
3 years, 7 months ago (2017-05-26 00:23:34 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2901183002/20001
3 years, 7 months ago (2017-05-26 03:56:53 UTC) #16
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 05:39:36 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6952c722b2c48bcc634950d6cbf1...

Powered by Google App Engine
This is Rietveld 408576698