Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(964)

Unified Diff: chrome/browser/chromeos/logging.cc

Issue 2901173002: Move RedirectChromeLogging to src/chromeos. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/logging.cc
diff --git a/chrome/browser/chromeos/logging.cc b/chrome/browser/chromeos/logging.cc
new file mode 100644
index 0000000000000000000000000000000000000000..f5205c6de74daaa22528f9744a0ad9aac80a519d
--- /dev/null
+++ b/chrome/browser/chromeos/logging.cc
@@ -0,0 +1,52 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/chromeos/logging.h"
+
+#include "base/command_line.h"
+#include "base/files/file_path.h"
+#include "base/logging.h"
+#include "chrome/common/logging_chrome.h"
+
+namespace logging {
+
+namespace {
+
+// This should be true for exactly the period between the end of
+// InitChromeLogging() and the beginning of CleanupChromeLogging().
+bool chrome_logging_redirected_ = false;
sky 2017/05/25 02:23:56 How about making this local to the function that u
achuithb 2017/05/25 10:06:06 Done.
+
+} // namespace
+
+void RedirectChromeLogging(const base::CommandLine& command_line) {
+ if (chrome_logging_redirected_) {
+ // TODO: Support multiple active users. http://crbug.com/230345
+ LOG(WARNING) << "NOT redirecting logging for multi-profiles case.";
+ return;
+ }
+
+ DCHECK(!chrome_logging_redirected_)
+ << "Attempted to redirect logging when it was already initialized.";
+
+ // Redirect logs to the session log directory, if set. Otherwise
+ // defaults to the profile dir.
+ const base::FilePath log_path = GetSessionLogFile(command_line);
+
+ // Always force a new symlink when redirecting.
+ const base::FilePath target_path = SetUpSymlinkIfNeeded(log_path, true);
+
+ // ChromeOS always logs through the symlink, so it shouldn't be
+ // deleted if it already exists.
+ logging::LoggingSettings settings;
+ settings.logging_dest = DetermineLogMode(command_line);
+ settings.log_file = log_path.value().c_str();
+ if (!logging::InitLogging(settings)) {
+ DLOG(ERROR) << "Unable to initialize logging to " << log_path.value();
+ RemoveSymlinkAndLog(log_path, target_path);
+ } else {
+ chrome_logging_redirected_ = true;
+ }
+}
+
+} // namespace logging

Powered by Google App Engine
This is Rietveld 408576698